Add unicorn/no-new-buffer and unicorn/prefer-spread only for supported Node version

Author: pvdlg

config/plugins.js

@@ -81,6 +81,9 @@ module.exports = {
 		// Disabled as the rule doesn't exclude scripts executed with `node` but not referenced in "bin". See https://github.com/mysticatea/eslint-plugin-node/issues/96
 		// 'node/shebang': 'error',
 		'node/no-deprecated-api': 'error',
-		'node/exports-style': ['error', 'module.exports']
+		'node/exports-style': ['error', 'module.exports'],
+		// Disable by default (override `plugin:unicorn/recommended`), will be enabled if supported by the Node version
+		'unicorn/prefer-spread': 'off',
+		'unicorn/no-new-buffer': 'off'
 	}
 };

lib/options-manager.js

@@ -82,11 +82,14 @@ const ENGINE_RULES = {
 	'prefer-rest-params': {
 		'6.0.0': 'error'
 	},
-	'prefer-spread': {
+	'unicorn/prefer-spread': {
 		'5.0.0': 'error'
 	},
 	'prefer-destructuring': {
 		'6.0.0': ['error', {array: true, object: true}, {enforceForRenamedProperties: true}]
+	},
+	'unicorn/no-new-buffer': {
+		'5.10.0': 'error'
 	}
 };
 

test/options-manager.js

@@ -173,7 +173,7 @@ test('buildConfig: engines: >=4', t => {
 	const config = manager.buildConfig({engines: {node: '>=4'}});
 
 	// Do not include rules for Node.js 5 and above
-	t.is(config.rules['prefer-spread'], undefined);
+	t.is(config.rules['unicorn/prefer-spread'], undefined);
 	// Do not include rules for Node.js 6 and above
 	t.is(config.rules['prefer-rest-params'], undefined);
 	t.is(config.rules['prefer-destructuring'], undefined);
@@ -185,7 +185,7 @@ test('buildConfig: engines: >=4.1', t => {
 	const config = manager.buildConfig({engines: {node: '>=5.1'}});
 
 	// Do not include rules for Node.js 5 and above
-	t.is(config.rules['prefer-spread'], 'error');
+	t.is(config.rules['unicorn/prefer-spread'], 'error');
 	// Do not include rules for Node.js 6 and above
 	t.is(config.rules['prefer-rest-params'], undefined);
 	t.is(config.rules['prefer-destructuring'], undefined);
@@ -197,7 +197,7 @@ test('buildConfig: engines: >=6', t => {
 	const config = manager.buildConfig({engines: {node: '>=6'}});
 
 	// Include rules for Node.js 5 and above
-	t.is(config.rules['prefer-spread'], 'error');
+	t.is(config.rules['unicorn/prefer-spread'], 'error');
 	// Include rules for Node.js 6 and above
 	t.is(config.rules['prefer-rest-params'], 'error');
 	t.deepEqual(config.rules['prefer-destructuring'], [
@@ -211,7 +211,7 @@ test('buildConfig: engines: >=8', t => {
 	const config = manager.buildConfig({engines: {node: '>=8'}});
 
 	// Include rules for Node.js 5 and above
-	t.is(config.rules['prefer-spread'], 'error');
+	t.is(config.rules['unicorn/prefer-spread'], 'error');
 	// Include rules for Node.js 6 and above
 	t.is(config.rules['prefer-rest-params'], 'error');
 	t.deepEqual(config.rules['prefer-destructuring'], [