Skip to content

Commit f7f7c42

Browse files
committed
fix issues with comments in columns
1 parent 6d65efd commit f7f7c42

File tree

13 files changed

+389
-258
lines changed

13 files changed

+389
-258
lines changed

.flake8

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
[flake8]
22
exclude = .github,.git,__pycache__,docs/source/conf.py,old,build,dist,simple_ddl_parser/parsetab.py,simple_ddl_parser/test.py
33
max-complexity = 10
4-
max-line-length = 120
4+
max-line-length = 120
5+
ignore = C901, W503

CHANGELOG.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
**v0.19.5**
2+
Fixes:
3+
4+
1. Fixed issues with COMMENT statement in column definitions. Add bunch of tests, now they expect working ok.
5+
6+
17
**v0.19.4**
28
1. Added support for PARTITION BY (previously was only PARTITIONED BY from HQL)
39

README.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,6 @@ You also can provide a path where you want to have a dumps with schema with argu
342342
1. Add more support for CREATE type IS TABLE (example: CREATE OR REPLACE TYPE budget_tbl_typ IS TABLE OF NUMBER(8,2);
343343
2. Add support (ignore correctly) ALTER TABLE ... DROP CONSTRAINT ..., ALTER TABLE ... DROP INDEX ...
344344
3. Add support for COMMENT ON statement
345-
4. Add support for case COMMENT column after DEFAULT word like `col1 int DEFAULT '1' COMMENT 'Integer Column'`
346345

347346
## non-feature todo
348347

@@ -357,7 +356,13 @@ For one of the work projects I needed to convert SQL ddl to Python ORM models in
357356
So I remembered about Parser in Fakeme and just extracted it & improved.
358357

359358
## Changelog
360-
**v0.19.3**
359+
**v0.19.5**
360+
Fixes:
361+
362+
1. Fixed issues with COMMENT statement in column definitions. Add bunch of tests, now they expect working ok.
363+
364+
365+
**v0.19.4**
361366
1. Added support for PARTITION BY (previously was only PARTITIONED BY from HQL)
362367

363368
**v0.19.2**

docs/README.rst

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,6 @@ TODO in next Releases (if you don't see feature that you need - open the issue)
386386
#. Add more support for CREATE type IS TABLE (example: CREATE OR REPLACE TYPE budget_tbl_typ IS TABLE OF NUMBER(8,2);
387387
#. Add support (ignore correctly) ALTER TABLE ... DROP CONSTRAINT ..., ALTER TABLE ... DROP INDEX ...
388388
#. Add support for COMMENT ON statement
389-
#. Add support for case COMMENT column after DEFAULT word like ``col1 int DEFAULT '1' COMMENT 'Integer Column'``
390389

391390
non-feature todo
392391
----------------
@@ -406,7 +405,13 @@ So I remembered about Parser in Fakeme and just extracted it & improved.
406405
Changelog
407406
---------
408407

409-
**v0.19.3**
408+
**v0.19.5**
409+
Fixes:
410+
411+
412+
#. Fixed issues with COMMENT statement in column definitions. Add bunch of tests, now they expect working ok.
413+
414+
**v0.19.4**
410415

411416

412417
#. Added support for PARTITION BY (previously was only PARTITIONED BY from HQL)

0 commit comments

Comments
 (0)