Skip to content

Commit de779f8

Browse files
committed
Fix TaskContextSuite.
1 parent cc152fc commit de779f8

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

core/src/test/scala/org/apache/spark/scheduler/TaskContextSuite.scala

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ import org.apache.spark.rdd.RDD
2929
class TaskContextSuite extends FunSuite with BeforeAndAfter with LocalSparkContext {
3030

3131
test("Calls executeOnCompleteCallbacks after failure") {
32-
var completed = false
32+
TaskContextSuite.completed = false
3333
sc = new SparkContext("local", "test")
3434
val rdd = new RDD[String](sc, List()) {
3535
override def getPartitions = Array[Partition](StubPartition(0))
3636
override def compute(split: Partition, context: TaskContext) = {
37-
context.addOnCompleteCallback(() => completed = true)
37+
context.addOnCompleteCallback(() => TaskContextSuite.completed = true)
3838
sys.error("failed")
3939
}
4040
}
@@ -44,8 +44,12 @@ class TaskContextSuite extends FunSuite with BeforeAndAfter with LocalSparkConte
4444
intercept[RuntimeException] {
4545
task.run(0)
4646
}
47-
assert(completed === true)
47+
assert(TaskContextSuite.completed === true)
4848
}
49+
}
4950

50-
case class StubPartition(index: Int) extends Partition
51+
private object TaskContextSuite {
52+
@volatile var completed = false
5153
}
54+
55+
private case class StubPartition(index: Int) extends Partition

0 commit comments

Comments
 (0)