Skip to content

Commit 96e50f9

Browse files
authored
Don't add series for missing row count (#474)
Some bechmarks don't include a series for all row count values. Don't add a chart if there is no data for the row count. Fixes an issue with the `ReadSchema` benchmark where we see multiple row count values even though we only populate one of them: <img width="828" alt="Screenshot 2024-11-20 at 12 33 13" src="https://github.com/user-attachments/assets/f129ebb3-46ae-43bc-864a-7dc404ff7a1c">
1 parent 481f1c6 commit 96e50f9

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

dev/benchmark-results/build.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,9 @@ func generateCharts(reports []BenchmarkReports) []*charts.Line {
177177

178178
for _, rowCount := range sortedRowCounts {
179179
s := series[rowCount]
180+
if len(s) == 0 {
181+
continue
182+
}
180183

181184
name := fmt.Sprintf("%d", rowCount)
182185
data := make([]opts.LineData, len(series[rowCount]))

0 commit comments

Comments
 (0)