diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 2932271b0..da3802d70 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -102,7 +102,7 @@ jobs: steps: - uses: actions/checkout@v4 with: - repository: "dcherian/xarray" + repository: "pydata/xarray" fetch-depth: 0 # Fetch all history for all branches and tags. - name: Set up conda environment uses: mamba-org/setup-micromamba@v1 @@ -116,7 +116,6 @@ jobs: pint>=0.22 - name: Install xarray run: | - git checkout flox-preserve-dtype python -m pip install --no-deps . - name: Install upstream flox run: | diff --git a/ci/env-numpy1.yml b/ci/env-numpy1.yml index 30dccdc0e..4ee2dd237 100644 --- a/ci/env-numpy1.yml +++ b/ci/env-numpy1.yml @@ -27,4 +27,4 @@ dependencies: - numbagg>=0.3 - hypothesis - pip: - - git+https://github.com/dcherian/xarray.git@flox-preserve-dtype + - git+https://github.com/dcherian/xarray.git diff --git a/ci/environment.yml b/ci/environment.yml index dac6880ac..970543e6f 100644 --- a/ci/environment.yml +++ b/ci/environment.yml @@ -27,4 +27,4 @@ dependencies: - numbagg>=0.3 - hypothesis - pip: - - git+https://github.com/dcherian/xarray.git@flox-preserve-dtype + - git+https://github.com/dcherian/xarray.git diff --git a/ci/no-dask.yml b/ci/no-dask.yml index fb2bac92d..a6492e268 100644 --- a/ci/no-dask.yml +++ b/ci/no-dask.yml @@ -22,4 +22,4 @@ dependencies: - numba - numbagg>=0.3 - pip: - - git+https://github.com/dcherian/xarray.git@flox-preserve-dtype + - git+https://github.com/dcherian/xarray.git diff --git a/ci/no-numba.yml b/ci/no-numba.yml index 8039b20f7..10de5d5d1 100644 --- a/ci/no-numba.yml +++ b/ci/no-numba.yml @@ -19,8 +19,9 @@ dependencies: - pytest-pretty - pytest-xdist - syrupy - - xarray - pre-commit - numpy_groupies>=0.9.19 - pooch - toolz + - pip: + - git+https://github.com/dcherian/xarray.git diff --git a/flox/aggregations.py b/flox/aggregations.py index 0906c8ccb..0ad659f4f 100644 --- a/flox/aggregations.py +++ b/flox/aggregations.py @@ -149,9 +149,9 @@ def size(self) -> int: class Aggregation: def __init__( self, - name, + name: str, *, - numpy: str | FuncTuple | None = None, + numpy: str | None = None, chunk: str | FuncTuple | None, combine: str | FuncTuple | None, preprocess: Callable | None = None, @@ -217,7 +217,7 @@ def __init__( self.preprocess = preprocess # Use "chunk_reduce" or "chunk_argreduce" self.reduction_type = reduction_type - self.numpy: FuncTuple = (numpy,) if numpy else (self.name,) + self.numpy: FuncTuple = (numpy,) if numpy is not None else (self.name,) # initialize blockwise reduction self.chunk: OptionalFuncTuple = _atleast_1d(chunk) # how to aggregate results after first round of reduction