From 100f60a9b4b8cbc4927a5fe418914b2ebb78f174 Mon Sep 17 00:00:00 2001 From: Deepak Cherian Date: Tue, 3 Oct 2023 21:38:35 -0600 Subject: [PATCH 1/3] repo-review comments xref #264 --- .pre-commit-config.yaml | 4 ++-- .readthedocs.yml | 18 ++++++++++++++++++ pyproject.toml | 5 ++++- 3 files changed, 24 insertions(+), 3 deletions(-) create mode 100644 .readthedocs.yml diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index e9b1e9d6b..b80dab93b 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -7,7 +7,7 @@ repos: rev: 'v0.0.276' hooks: - id: ruff - args: ["--fix"] + args: ["--fix", "--show-fixes"] - repo: https://github.com/pre-commit/pre-commit-hooks rev: v4.4.0 @@ -17,7 +17,7 @@ repos: - id: end-of-file-fixer - id: check-docstring-first - - repo: https://github.com/psf/black + - repo: https://github.com/psf/black-pre-commit-mirror rev: 23.3.0 hooks: - id: black diff --git a/.readthedocs.yml b/.readthedocs.yml new file mode 100644 index 000000000..7e4965745 --- /dev/null +++ b/.readthedocs.yml @@ -0,0 +1,18 @@ +# Read the Docs configuration file +# See https://docs.readthedocs.io/en/stable/config-file/v2.html for details + +version: 2 + +build: + os: ubuntu-22.04 + tools: + python: "3.11" +sphinx: + configuration: docs/conf.py + +python: + install: + - method: pip + path: . + extra_requirements: + - docs diff --git a/pyproject.toml b/pyproject.toml index e41fb17eb..f0ecb19aa 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -41,7 +41,6 @@ requires = [ "numpy_groupies>=0.9.19", "toolz", "setuptools>=61.0.0", - "wheel", "setuptools_scm[toml]>=7.0", ] build-backend = "setuptools.build_meta" @@ -77,6 +76,8 @@ ignore = [ "E731", ] select = [ + # Bugbear + "B", # Pyflakes "F", # Pycodestyle @@ -124,6 +125,8 @@ ignore_missing_imports = true [tool.pytest.ini_options] addopts = "--tb=short" +minversion = "7" +testpaths = ["tests"] [tool.codespell] From ccd3ec1762e01a5fc6c9d3b5716cbc09b6bbc159 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed, 4 Oct 2023 03:41:53 +0000 Subject: [PATCH 2/3] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- flox/visualize.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flox/visualize.py b/flox/visualize.py index 7d44c7d91..17c0a6596 100644 --- a/flox/visualize.py +++ b/flox/visualize.py @@ -179,7 +179,7 @@ def _visualize_cohorts(by, cohorts, ax=None): def visualize_groups_2d(labels, y0=0, **kwargs): colors = mpl.cm.tab10_r - for i, chunk in enumerate(labels): + for _i, chunk in enumerate(labels): chunk = np.atleast_2d(chunk) draw_mesh( *chunk.shape, From 89c7a81a5ae4bfb6b4ed9d115fd3b45ac3667cc1 Mon Sep 17 00:00:00 2001 From: Deepak Cherian Date: Wed, 11 Oct 2023 11:40:25 -0600 Subject: [PATCH 3/3] Update pyproject.toml --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index f0ecb19aa..83cd04252 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -77,7 +77,7 @@ ignore = [ ] select = [ # Bugbear - "B", + # "B", # Pyflakes "F", # Pycodestyle