Merge pull request #1986 from xamarin/phonedialer-surface-exception

jfversluis · web-flow · commit 101971ffb0d6 · 2022-04-05T11:27:20.000+02:00
Surface exception for not supported phone number on iOS PhoneDialer
diff --git a/Xamarin.Essentials/PhoneDialer/PhoneDialer.ios.cs b/Xamarin.Essentials/PhoneDialer/PhoneDialer.ios.cs
@@ -11,12 +11,12 @@ public static partial class PhoneDialer
 
         internal static bool IsSupported => UIApplication.SharedApplication.CanOpenUrl(CreateNsUrl(new string('0', 10)));
 
-        static async void PlatformOpen(string number)
+        static void PlatformOpen(string number)
         {
             ValidateOpen(number);
 
             var nsUrl = CreateNsUrl(number);
-            await Launcher.PlatformOpenAsync(nsUrl);
+            Launcher.PlatformOpenAsync(nsUrl);
         }
 
         static NSUrl CreateNsUrl(string number) => new NSUrl(new Uri($"tel:{number}").AbsoluteUri);

Original file line number	Diff line number	Diff line change
`@@ -11,12 +11,12 @@ public static partial class PhoneDialer`
`11`	`11`
`12`	`12`	`internal static bool IsSupported => UIApplication.SharedApplication.CanOpenUrl(CreateNsUrl(new string('0', 10)));`
`13`	`13`
`14`		`- static async void PlatformOpen(string number)`
	`14`	`+ static void PlatformOpen(string number)`
`15`	`15`	`{`
`16`	`16`	`ValidateOpen(number);`
`17`	`17`
`18`	`18`	`var nsUrl = CreateNsUrl(number);`
`19`		`- await Launcher.PlatformOpenAsync(nsUrl);`
	`19`	`+ Launcher.PlatformOpenAsync(nsUrl);`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`static NSUrl CreateNsUrl(string number) => new NSUrl(new Uri($"tel:{number}").AbsoluteUri);`