fixed bug where light of the sun was not affected by the transmiatance of the atmosphere

Author: wpsimon09

Internal/Application/ApplicationState/ApplicationState.cpp

@@ -117,16 +117,6 @@ AtmosphereParameters* ApplicationState::GetAtmosphereParameters()
 void ApplicationState::pSetAtmosphereParameters(AtmosphereParameters* pAtmosphereParams)
 {
     m_atmosphereParams = pAtmosphereParams;
-    // TODO: for now i dont know of better place to tell renderer that it should attenuate sun based on the zenith angle
-    m_globalRenderingInfo->accountForAtmosphereTransmitance = static_cast<bool>(pAtmosphereParams->booleans.z);
-    // camera position in global data is going to be bottom sphere radius
-    m_globalRenderingInfo->atmosphereParams.x = pAtmosphereParams->groundAlbedo.w;
-    m_globalRenderingInfo->atmosphereParams.y = pAtmosphereParams->rayleighScattering.w;
-
-    // for the new packed type
-    m_globalRenderingData2->atmosphereParams.x = pAtmosphereParams->groundAlbedo.w;        // top radius
-    m_globalRenderingData2->atmosphereParams.y = pAtmosphereParams->rayleighScattering.w;  // botom radius
-    m_globalRenderingData2->atmosphereParams.z = static_cast<bool>(pAtmosphereParams->booleans.z);  // account for transmitance in the light calculations
 }
 
 void ApplicationState::pSetGlobalRenderingInfoData2(GlobalRenderingInfo2* pGlobalRenderingInfo)

Internal/Application/Client.cpp

@@ -150,7 +150,17 @@ void Client::UpdateCamera(CameraUpdateInfo& cameraUpdateInfo)
     m_globalRenderingData2.inverseProj = m_camera->GetinverseProjectionMatrix();
 
 
-    m_globalRenderingData2.atmosphereParams = glm::vec4(0);
+    
+    if(m_applicationState->GetAtmosphereParameters()){
+        auto ap = m_applicationState->GetAtmosphereParameters();
+        m_globalRenderingData2.atmosphereParams = glm::vec4(
+            ap->groundAlbedo.w,
+            ap->rayleighScattering.w,
+            static_cast<bool>(ap->booleans.z),
+            0.0
+        );
+    }
+    
     m_globalRenderingData2.cameraPosition   = glm::vec4(m_camera->GetPosition(), m_camera->GetFOVRad());
 
     //========================

Internal/Vulkan/Utils/VUniformBufferManager/UnifromsRegistry.hpp

@@ -57,7 +57,7 @@ struct GlobalRenderingInfo2
     glm::mat4 viewPrevFrame = glm::mat4(1.0);
     glm::mat4 projPrevFrame = glm::mat4(1.0);
 
-    glm::vec4 atmosphereParams;
+    glm::vec4 atmosphereParams; // x - bottom radius , y - top radius, z - account for scattering
     glm::vec4 cameraPosition;
     glm::vec4 viewParams;   // x - image plane distance, y - focal length, z - near plane, w -far plane
     glm::vec4 viewParams2;  // x - FOV, y - aspect ratio, z - aparature size, w -cameraType