Skip to content

Commit ea841e8

Browse files
authored
Merge pull request #1104 from webrtcHacks/test-style
test: modernize getusermedia-mocha
2 parents 95d813f + 9023ef2 commit ea841e8

File tree

1 file changed

+12
-14
lines changed

1 file changed

+12
-14
lines changed

test/getusermedia-mocha.js

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,25 +7,21 @@
77
*/
88
/* eslint-env node */
99
/* global beforeEach, afterEach */
10-
'use strict';
1110

1211
/* wrap navigator.getUserMedia and navigator.mediaDevices.getUserMedia
1312
* so that any streams acquired are released after each test.
1413
*/
1514
beforeEach(() => {
16-
let streams = [];
17-
let release = () => {
15+
const streams = [];
16+
const release = () => {
1817
streams.forEach((stream) => {
19-
stream.getTracks().forEach((track) => {
20-
track.stop();
21-
});
18+
stream.getTracks().forEach((track) => track.stop());
2219
});
23-
streams = [];
20+
streams.length = 0;
2421
};
2522

26-
2723
if (navigator.getUserMedia) {
28-
let origGetUserMedia = navigator.getUserMedia.bind(navigator);
24+
const origGetUserMedia = navigator.getUserMedia.bind(navigator);
2925
navigator.getUserMedia = (constraints, cb, eb) => {
3026
origGetUserMedia(constraints, (stream) => {
3127
streams.push(stream);
@@ -40,13 +36,14 @@ beforeEach(() => {
4036
};
4137
}
4238

43-
let origMediaDevicesGetUserMedia =
39+
const origMediaDevicesGetUserMedia =
4440
navigator.mediaDevices.getUserMedia.bind(navigator.mediaDevices);
4541
navigator.mediaDevices.getUserMedia = (constraints) => {
46-
return origMediaDevicesGetUserMedia(constraints, (stream) => {
47-
streams.push(stream);
48-
return stream;
49-
});
42+
return origMediaDevicesGetUserMedia(constraints)
43+
.then((stream) => {
44+
streams.push(stream);
45+
return stream;
46+
});
5047
};
5148
navigator.mediaDevices.getUserMedia.restore = () => {
5249
navigator.mediaDevices.getUserMedia = origMediaDevicesGetUserMedia;
@@ -60,3 +57,4 @@ afterEach(() => {
6057
}
6158
navigator.mediaDevices.getUserMedia.restore();
6259
});
60+

0 commit comments

Comments
 (0)