Stop appending empty fragment to urls pointing ad no fragment identifier

Munter · Munter · commit d0f9ed564367 · 2018-07-24T01:40:59.000+02:00
diff --git a/src/components/SidebarItem/SidebarItem.jsx b/src/components/SidebarItem/SidebarItem.jsx
@@ -89,6 +89,10 @@ export default class SidebarItem extends React.Component {
     if ( `/${currentPage}` === url ) {
       return `#${anchor.id}`;
 
-    } else return `${url}#${anchor.id}`;
+    } else if (!anchor.id) {
+      return url;
+    } else {
+      return `${url}#${anchor.id}`;
+    }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,10 @@ export default class SidebarItem extends React.Component {`
`89`	`89`	if ( `/${currentPage}` === url ) {
`90`	`90`	return `#${anchor.id}`;
`91`	`91`
`92`		- } else return `${url}#${anchor.id}`;
	`92`	`+ } else if (!anchor.id) {`
	`93`	`+ return url;`
	`94`	`+ } else {`
	`95`	+ return `${url}#${anchor.id}`;
	`96`	`+ }`
`93`	`97`	`}`
`94`	`98`	`}`