fix: configs property for --devtool#2603
Merged
alexander-akait merged 3 commits intomasterfrom Apr 7, 2021
Merged
Conversation
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Only for webpack v5, we already support it
Member
Author
|
I see then we should remove |
Member
Author
Member
|
yep, okay, let's do it, but I don't want to accept any bugfixes/features (expect security bugs for v4), because when we will drop webpack v4 we will remove these flags |
Member
Author
|
Makes sense 👍🏻 |
Codecov Report
@@ Coverage Diff @@
## master #2603 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 29 29
Lines 1480 1480
Branches 425 425
=======================================
Hits 1352 1352
Misses 128 128
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Apr 6, 2021
Member
Author
|
/cc @webpack/cli-team |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
devtoolcan also acceptfalse.Does this PR introduce a breaking change?
No
Other information
None