fix: fix error message on invalid plugin options#2380
Merged
alexander-akait merged 2 commits intomasterfrom Jan 28, 2021
Merged
fix: fix error message on invalid plugin options#2380alexander-akait merged 2 commits intomasterfrom
alexander-akait merged 2 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2380 +/- ##
==========================================
+ Coverage 70.50% 70.52% +0.02%
==========================================
Files 47 47
Lines 2156 2158 +2
Branches 561 563 +2
==========================================
+ Hits 1520 1522 +2
Misses 636 636
Continue to review full report at Codecov.
|
alexander-akait
deleted the
fix-error-message-on-invalid-plugin-options
branch
snitin315
pushed a commit
to snitin315/webpack-cli
that referenced
this pull request
Feb 6, 2021
This was referenced Mar 6, 2021
This was referenced Mar 13, 2021
Closed
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
No need
Summary
We should not output error stack for validation errors inside plugins
Does this PR introduce a breaking change?
No
Other information
No