fix: defer setting default mode to core#2095
Merged
alexander-akait merged 4 commits intowebpack:masterfrom Nov 11, 2020
Merged
Conversation
alexander-akait
previously approved these changes
Nov 10, 2020
snitin315
previously approved these changes
Nov 10, 2020
rishabh3112
previously approved these changes
Nov 10, 2020
anshumanv
dismissed stale reviews from rishabh3112, snitin315, and alexander-akait
via
d1f9bbd
Codecov Report
@@ Coverage Diff @@
## master #2095 +/- ##
==========================================
+ Coverage 68.61% 68.65% +0.03%
==========================================
Files 74 74
Lines 2390 2393 +3
Branches 508 510 +2
==========================================
+ Hits 1640 1643 +3
Misses 750 750
Continue to review full report at Codecov.
|
snitin315
previously approved these changes
Nov 10, 2020
Member
|
/cc @anshumanv need fix tests |
alexander-akait
previously approved these changes
Nov 10, 2020
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Feel free to merge on green
snitin315
reviewed
Nov 11, 2020
test/colors/colors.test.js
Outdated
Comment on lines
+29
to
+30
| '--mode', | ||
| 'production', |
Member
There was a problem hiding this comment.
I think it will be better to define mode: production inside the config.
Member
|
@anshumanv We need fix test for stats and watch, let's add |
Member
Author
|
should be good now |
alexander-akait
approved these changes
Nov 11, 2020
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Not needed I think
Summary
Does this PR introduce a breaking change?
Nope
Other information