fix: warning should not result in non-zero exit code#1872
Merged
Conversation
snitin315
force-pushed
the
fix/exit-codes
branch
from
8d71782 to
93aa603
Compare
alexander-akait
approved these changes
Oct 5, 2020
Member
|
/cc @webpack/cli-team |
anshumanv
approved these changes
Oct 5, 2020
jamesgeorge007
approved these changes
Oct 5, 2020
Dheeraj-01
approved these changes
Oct 5, 2020
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @Dheeraj-01 Please review the new changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
A warning should not result in a non-zero exit code as it's not braking build or something else.
Refers #1836 (comment)
Does this PR introduce a breaking change?
No
Other information
Fixes #1836