Skip to content

feat: add support to spawn multiple compilers with different configs#1765

Merged
anshumanv merged 9 commits intowebpack:nextfrom
anshumanv:multi-config
Aug 25, 2020
Merged

feat: add support to spawn multiple compilers with different configs#1765
anshumanv merged 9 commits intowebpack:nextfrom
anshumanv:multi-config

Conversation

@anshumanv
Copy link
Copy Markdown
Member

@anshumanv anshumanv commented Aug 21, 2020

What kind of change does this PR introduce?

feat

Did you add tests for your changes?
yes

If relevant, did you update the documentation?
yes

Summary

  • Make config flag support multiple config
  • when multiple configs are supplied they are passed to the compiler as array webpack([{...}, {...}]) which spawn multiple compilers
  • In case of single config, resolved config object is passed directly

Does this PR introduce a breaking change?
No

Other information

@anshumanv
Copy link
Copy Markdown
Member Author

anshumanv commented Aug 21, 2020

wip now

@anshumanv anshumanv marked this pull request as ready for review August 22, 2020 10:21
@anshumanv anshumanv requested a review from a team as a code owner August 22, 2020 10:21
@anshumanv anshumanv changed the title feat: add support for multi config feat: add support to spawn multiple compilers with different configs Aug 22, 2020
evenstensberg
evenstensberg previously approved these changes Aug 23, 2020
snitin315
snitin315 previously approved these changes Aug 24, 2020
rishabh3112
rishabh3112 previously approved these changes Aug 24, 2020
@webpack-bot
Copy link
Copy Markdown

@anshumanv Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@jamesgeorge007 Please review the new changes.

@anshumanv
Copy link
Copy Markdown
Member Author

/cc @webpack/cli-team

@alexander-akait
Copy link
Copy Markdown
Member

/cc @evenstensberg

@anshumanv
Copy link
Copy Markdown
Member Author

Merging, thanks for the feedback everyone! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants