fix: prevent info from running unnecessarily#1650
Merged
jamesgeorge007 merged 7 commits intowebpack:nextfrom Jun 30, 2020
Merged
fix: prevent info from running unnecessarily#1650jamesgeorge007 merged 7 commits intowebpack:nextfrom
jamesgeorge007 merged 7 commits intowebpack:nextfrom
Conversation
c567f07 to
927bce2
Compare
0dda8b5 to
397440a
Compare
397440a to
22750e4
Compare
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Good work, can you provide example of --help, because now commander can do it, also i think here couple places for refactoring, but it is not high priority right now
Member
Author
|
⬡ webpack ⬡
https://webpack.js.org
The build tool for modern web applications
Usage: `webpack [...options] | <command>`
Example: `webpack help --flag | <command>`
Available Commands
init | c Initialize a new webpack configuration
migrate | m Migrate a configuration to a new version
loader | l Scaffold a loader repository
plugin | p Scaffold a plugin repository
info | i Outputs information about your system and dependencies
serve | s Run the webpack Dev Server
Options
--entry string[] The entry point(s) of your application e.g.
./src/main.js
-c, --config string Provide path to a webpack configuration file e.g.
./webpack.config.js
-m, --merge string Merge a configuration file using webpack-merge e.g.
./webpack.config.js
--progress Print compilation progress during build
--silent Disable any output that webpack makes
--help Outputs list of supported flags
-o, --output string Output location of the file generated by webpack
e.g. ./dist/
-t, --target string Sets the build target e.g. node
-w, --watch Watch for files changes
-h, --hot Enables Hot Module Replacement
--no-hot Disables Hot Module Replacement
-s, --sourcemap string Determine source maps to use
--prefetch string Prefetch this request
-j, --json Prints result as JSON
-d, --dev Run development build
-p, --prod Run production build
--mode string Defines the mode to pass to webpack
-v, --version Get current version
--node-args string[] NodeJS flags
--stats string It instructs webpack on how to treat the stats e.g.
verbose
--verbose It tells webpack to output all the information
--env string Environment passed to the configuration when it is a
function
Made with ♥️ by the webpack team |
Member
Author
|
Let's revisit the refactoring part in a future PR 👍 |
alexander-akait
previously approved these changes
Jun 29, 2020
Member
alexander-akait
left a comment
There was a problem hiding this comment.
/cc @webpack/cli-team
snitin315
previously approved these changes
Jun 29, 2020
|
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @snitin315 Please review the new changes. |
58b7db2 to
22750e4
Compare
ca7b939
22750e4 to
ca7b939
Compare
ca7b939 to
b746c68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yup
If relevant, did you update the documentation?
Nope
Summary
commander.jsto parse the available commands.infofrom running unnecessarily.Does this PR introduce a breaking change?
Nope
Other information
N/A