tests(utils): add packageUtils tests#1375
Merged
alexander-akait merged 7 commits intowebpack:nextfrom Mar 25, 2020
Merged
Conversation
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
snitin315
approved these changes
Mar 25, 2020
anshumanv
approved these changes
Mar 25, 2020
Member
anshumanv
left a comment
anshumanv
left a comment
There was a problem hiding this comment.
Those are some comprehensive tests, well done!
jamesgeorge007
approved these changes
Mar 25, 2020
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
tests/fix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
N/A
Summary
I added tests for the
packageUtilsfile.I also made some fixes and changes to the
getPackageManagerfunction. If ayarn.lockis not present but apackage-lock.jsonis present, I think we should assume the user wants to use npm.Does this PR introduce a breaking change?
Yes, as noted above in the
getPackageManagerfunctionOther information