Skip to content

chore: Minor typographical fixes#1183

Merged
rishabh3112 merged 2 commits intowebpack:nextfrom
jamesgeorge007:hotfix/grammatical-tweak
Jan 23, 2020
Merged

chore: Minor typographical fixes#1183
rishabh3112 merged 2 commits intowebpack:nextfrom
jamesgeorge007:hotfix/grammatical-tweak

Conversation

@jamesgeorge007
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

Did you add tests for your changes?
N/A

If relevant, did you update the documentation?
Nope

Summary
Follow up of #1141

Does this PR introduce a breaking change?

Nope

Other information
N/A

@webpack-bot
Copy link
Copy Markdown

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Copy Markdown
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR!
There is a similar typographical mistake in commands.js file.
Please correct it too 😅

@webpack-bot
Copy link
Copy Markdown

@jamesgeorge007 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@rishabh3112 Please review the new changes.

Copy link
Copy Markdown
Contributor

@jeffin143 jeffin143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesgeorge007 jamesgeorge007 changed the title chore: Minor typographical fix chore: Minor typographical fixes Jan 23, 2020
@rishabh3112 rishabh3112 merged commit a0ac134 into webpack:next Jan 23, 2020
@jamesgeorge007 jamesgeorge007 deleted the hotfix/grammatical-tweak branch January 23, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants