fix: remove for now the default value of the target#1171
Merged
ematipico merged 1 commit intowebpack:nextfrom Jan 17, 2020
Merged
fix: remove for now the default value of the target#1171ematipico merged 1 commit intowebpack:nextfrom
ematipico merged 1 commit intowebpack:nextfrom
Conversation
chores: removed colour from table head (red is not good) and emitted a more precise value of the bundle size
ematipico
force-pushed
the
bugfix/target-fix
branch
from
678e6ae to
e804f25
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chores: removed colour from table head (red is not good) and emitted a more precise value of the bundle size
What kind of change does this PR introduce?
Closes #1169
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Not needed
Summary
I removed the target. Webpack already has a default which is
target: "web"so the cli doesn't need to have it too.Does this PR introduce a breaking change?
Nope
Other information
Added some chores around the emitted output