chore: wip

chore: make the code more consise

Author: evenstensberg

lib/groups/basic.js

@@ -4,46 +4,23 @@ class BasicGroup extends GroupHelper {
     constructor(options) {
         super(options);
         this.WEBPACK_OPTION_FLAGS = ['prod', 'dev', 'watch', 'w', 'prod', 'p', 'interactive', 'i'];
-        this.resolveFlags();
     }
     resolveFlags() {
         const { args } = this;
 
-        const old_args = Object.keys(args);
-        const newArgs = old_args
-            .map(arg => {
-                if (arg === 'entry') {
-                    const isCJS = args[arg] === null;
-                    if (isCJS) {
-                        args['dev'] = true;
-                        args['prod'] = false;
-                    } else {
-                        args['prod'] = true;
-                        args['dev'] = false;
-                    }
-                }
-                if (arg === 'interactive') {
-                    args['interactive'] = true;
-                }
-                return arg;
-            })
-            .filter(e => e);
-
-        newArgs.forEach(arg => {
+        Object.keys(args).forEach(arg => {
             if (this.WEBPACK_OPTION_FLAGS.includes(arg)) {
-                this.opts.outputOptions[arg] = this.resolveWebpackOptions(arg, args[arg]);
+                this.opts.outputOptions[arg] = args[arg];
             }
             if (arg == 'analyze') {
                 const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer');
                 this.opts.options.plugins = [new BundleAnalyzerPlugin()];
             }
             if (arg == 'sourcemap') {
-                this.opts.options.devtool = args[arg] || 'eval';
+                this.opts.options.devtool = args[arg];
             }
             if (arg == 'entry') {
-                if (args[arg] === 'help') {
-                    return;
-                }
+                args[arg] = args[arg] || '';
                 this.opts.options[arg] = this.resolveFilePath(args[arg], 'index');
             }
         });
@@ -52,10 +29,8 @@ class BasicGroup extends GroupHelper {
         }
     }
 
-    resolveWebpackOptions(key, val) {
-        return val;
-    }
     run() {
+        this.resolveFlags();
         return this.opts;
     }
 }

lib/utils/group-helper.js

@@ -111,7 +111,7 @@ class GroupHelper {
         options.plugins.unshift(plugin);
     }
 
-    resolveFilePath(filename = null, defaultValue) {
+    resolveFilePath(filename='', defaultValue) {
         if (filename && Array.isArray(filename)) {
             return filename.map(fp => this.resolveFilePath(fp, defaultValue)).filter(e => e);
         }
@@ -122,8 +122,8 @@ class GroupHelper {
             defaultValue = defaultValue + '.js';
         }
         let configPath;
-        const predefinedConfigPath = filename ? resolve(process.cwd(), filename) : null;
-        const configPathExists = predefinedConfigPath ? existsSync(predefinedConfigPath) : false;
+        const predefinedConfigPath = filename ? resolve(process.cwd(), filename) : undefined;
+        const configPathExists = predefinedConfigPath ? existsSync(predefinedConfigPath) : undefined;
 
         if (!configPathExists) {
             let LOOKUP_PATHS = [`${filename}`, `src/${filename}`, defaultValue, `src/${defaultValue}`];