chore(serve): remove promise return from serve package (#1091)

Author: knagaitsev

packages/serve/index.ts

@@ -12,7 +12,7 @@ import { core } from "../../lib/utils/cli-flags";
  * @param {String[]} args - args processed from the CLI
  * @returns {Function} invokes the devServer API
  */
-export default function serve(args): Promise<void | Function> {
+export default function serve(args): void {
 	const cli = new WebpackCLI();
 	// partial parsing usage: https://github.com/75lb/command-line-args/wiki/Partial-parsing
 
@@ -27,9 +27,7 @@ export default function serve(args): Promise<void | Function> {
 	if (webpackArgs && webpackArgs._all && typeof webpackArgs._all.hot !== 'undefined') {
 		finalArgs['hot'] = webpackArgs._all.hot;
 	}
-    return new Promise((resolve): void => {
-		cli.getCompiler(webpackArgs, core).then((compiler): void => {
-			startDevServer.default(compiler, finalArgs, resolve);
-		});
+	cli.getCompiler(webpackArgs, core).then((compiler): void => {
+		startDevServer.default(compiler, finalArgs);
 	});
 }

packages/serve/startDevServer.ts

@@ -6,11 +6,10 @@ import * as Server from "webpack-dev-server/lib/Server";
  *
  * @param {Object} compiler - a webpack compiler
  * @param {Object} options - devServer options
- * @param {Function} onListening - optional callback for when the server starts listening
  * 
  * @returns {Void} 
  */
-export default function startDevServer(compiler, options, onListening): void {
+export default function startDevServer(compiler, options): void {
     const firstWpOpt = compiler.compilers
         ? compiler.compilers[0].options
         : compiler.options;
@@ -33,8 +32,5 @@ export default function startDevServer(compiler, options, onListening): void {
         if (err) {
             throw err;
         }
-        if (typeof onListening === 'function') {
-            onListening();
-        }
     });
 }