webpack scrypt.js: Critical dependency: the request of a dependency is an expression

[dankins]

Description

Building on v.1.2.1 using create-react-app fails due to webpack warning /node_modules/web3-eth-accounts/src/scrypt.js Critical dependency: the request of a dependency is an expression" when CI=true (ie, fail on warnings)

Expected behavior

Building a create-react-app using webpack should succeed

Actual behavior

I am able to build everything locally, however the build fails in my CI environment. The warning is as follows:

/node_modules/web3-eth-accounts/src/scrypt.js
Critical dependency: the request of a dependency is an expression

I assume it is a result of this line:
https://github.com/ethereum/web3.js/blob/1.x/packages/web3-eth-accounts/src/scrypt.js#L17

Steps to reproduce the behavior

Error Logs

Creating an optimized production build...

Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.

Failed to compile.

/home/circleci/project/node_modules/web3-eth-accounts/src/scrypt.js
Critical dependency: the request of a dependency is an expression


info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

lerna ERR! yarn run build stderr:
error Command failed with exit code 1.

Gists

Versions

• web3.js: v1.2.1
• nodejs: v10.16.0
• browser: circleci
• ethereum node:

[nivida]

Thanks for opening this issue! We will fix and release it asap.
The current workaround for you would be to suppress the webpack warning.

[Matelasse]

@nivida This is getting obnoxious and upvotes are increasing in number. How can we help to resolve this?

[michaelsbradleyjr]

@Matelasse I'm working on a PR, at the request of @nivida, hopefully will have it up for review by tomorrow, I've just been pretty pressed for time this week.

See: #2938 (comment).

The webpack warning is just a warning, and it should be possible in your build pipeline or whatever to ignore it instead of failing (i.e. if you're experiencing a build failure — maybe check it's just a warning for you and not an actual failure).

My apologies for any frustration this has caused.

[michaelsbradleyjr]

It’s currently a WIP, will be continuing today.

[wickstjo]

Could someone please clarify how to actually fix the warning?

[talaikis]

Could someone please clarify how to actually fix the warning?

Setting CI=false inside create-react-app .env, allows to build it.

[jjhesk]

got the same problem here