Skip to content

Commit 89c11ee

Browse files
olizillajohndmulhausen
authored andcommitted
fix: force webpack to load ESM config (#247)
Since node v16.6 webpack-cli fails to load esm config unless WEBPACK_CLI_FORCE_LOAD_ESM_CONFIG=true see: nodejs/node#39175 see: https://github.com/webpack/webpack-cli/blob/a660ffcbeb2807bce1554f787297e697464abd59/packages/webpack-cli/lib/webpack-cli.js#L50-L51 License: (Apache-2.0 AND MIT) Signed-off-by: Oli Evans <[email protected]>
1 parent 151ca07 commit 89c11ee

File tree

9 files changed

+11
-11
lines changed

9 files changed

+11
-11
lines changed

.github/workflows/api.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- uses: microsoft/playwright-github-action@v1
2222
- uses: actions/setup-node@v2
2323
with:
24-
node-version: 16.5
24+
node-version: 16
2525
- uses: bahmutov/npm-install@v1
2626
- run: npm run build --workspace packages/api
2727
- run: npm test --workspace packages/api
@@ -35,7 +35,7 @@ jobs:
3535
- uses: actions/checkout@v2
3636
- uses: actions/setup-node@v2
3737
with:
38-
node-version: 16.5
38+
node-version: 16
3939
- uses: bahmutov/npm-install@v1
4040
- name: Publish api worker
4141
# workaround for https://github.com/cloudflare/wrangler-action/issues/59 to use node 16

.github/workflows/client.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
- uses: actions/checkout@v2
1515
- uses: actions/setup-node@v2
1616
with:
17-
node-version: 16.5
17+
node-version: 16
1818
- uses: bahmutov/npm-install@v1
1919
- run: npm run build --workspace packages/client
2020
- run: npm test --workspace packages/client

.github/workflows/cron-pinata.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- name: Setup node
1919
uses: actions/setup-node@v1
2020
with:
21-
node-version: 16.5
21+
node-version: 16
2222

2323
- name: Install dependencies
2424
uses: bahmutov/npm-install@v1

.github/workflows/cron-pins.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- name: Setup node
1919
uses: actions/setup-node@v1
2020
with:
21-
node-version: 16.5
21+
node-version: 16
2222

2323
- name: Install dependencies
2424
uses: bahmutov/npm-install@v1

.github/workflows/db.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
- uses: actions/checkout@v2
2525
- uses: actions/setup-node@v2
2626
with:
27-
node-version: 16.5
27+
node-version: 16
2828
- uses: bahmutov/npm-install@v1
2929
- name: Update FaunaDB resources
3030
run: npm run import -w packages/db

.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ jobs:
1414
- uses: actions/checkout@v2
1515
- uses: actions/setup-node@v2
1616
with:
17-
node-version: 16.5
17+
node-version: 16
1818
- uses: bahmutov/npm-install@v1
1919
- run: npm run lint

.github/workflows/w3.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- uses: actions/checkout@v2
2121
- uses: actions/setup-node@v2
2222
with:
23-
node-version: 16.5
23+
node-version: 16
2424
# Only install the deps directly listed... dont do workspace magic.
2525
# Running install from the root gets you all the deps for all the packages.
2626
# which can easily mask missing deps if another modules also depends on it.

.github/workflows/website.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- uses: actions/checkout@v2
2121
- uses: actions/setup-node@v2
2222
with:
23-
node-version: 16.5
23+
node-version: 16
2424
- uses: bahmutov/npm-install@v1
2525
- run: npm test --workspace packages/website
2626

@@ -33,7 +33,7 @@ jobs:
3333
- uses: actions/checkout@v2
3434
- uses: actions/setup-node@v2
3535
with:
36-
node-version: 16.5
36+
node-version: 16
3737
- uses: bahmutov/npm-install@v1
3838
- run: npm run build -w packages/client
3939
- run: npm run build -w packages/website

packages/api/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"start": "wrangler dev --env $(whoami)",
1212
"dev": "wrangler dev --env $(whoami)",
1313
"publish": "wrangler publish --env $(whoami)",
14-
"build": "webpack",
14+
"build": "WEBPACK_CLI_FORCE_LOAD_ESM_CONFIG=true webpack",
1515
"test": "npm-run-all -p -r mock:cluster mock:db test:e2e -s test:size",
1616
"test:size": "bundlesize",
1717
"test:e2e": "playwright-test \"test/**/*.spec.js\" --sw src/index.js -b webkit",

0 commit comments

Comments
 (0)