Remove duplicate or redundant throws declarations (#1864)

Also, enable the corresponding IntelliJ IDEA inspection to catch similar
issues in the future.

Author: liblit

.idea/inspectionProfiles/No_Back_Sliding.xml

@@ -2727,7 +2727,7 @@ private CAstNode makeVarRef(String varName) {
   /** parse the JavaScript code using Rhino, and then translate the resulting AST to CAst */
   @Override
   public CAstEntity translateToCAst()
-      throws Error, IOException, com.ibm.wala.cast.ir.translator.TranslatorToCAst.Error {
+      throws IOException, com.ibm.wala.cast.ir.translator.TranslatorToCAst.Error {
     class CAstErrorReporter implements ErrorReporter {
       private final Set<Warning> w = HashSetFactory.make();
 

cast/js/rhino/src/main/java/com/ibm/wala/cast/js/translator/RhinoToAstTranslator.java

@@ -1,6 +1,5 @@
 package com.ibm.wala.cast.js.rhino.callgraph.fieldbased.test;
 
-import com.ibm.wala.cast.ir.translator.TranslatorToCAst.Error;
 import com.ibm.wala.cast.js.html.DefaultSourceExtractor;
 import com.ibm.wala.cast.js.ipa.callgraph.JSCallGraph;
 import com.ibm.wala.cast.js.ipa.callgraph.JSCallGraphUtil;
@@ -35,14 +34,14 @@ public void setUp() throws Exception {
 
   protected JSCallGraph runTest(
       String script, List<GraphAssertion> assertions, BuilderType... builderTypes)
-      throws WalaException, Error, CancelException {
+      throws WalaException, CancelException {
     return runTest(
         TestFieldBasedCG.class.getClassLoader().getResource(script), assertions, builderTypes);
   }
 
   protected JSCallGraph runTest(
       URL url, List<GraphAssertion> assertions, BuilderType... builderTypes)
-      throws WalaException, Error, CancelException {
+      throws WalaException, CancelException {
     JSCallGraph cg = null;
     for (BuilderType builderType : builderTypes) {
       IProgressMonitor monitor = ProgressMaster.make(new NullProgressMonitor(), 45000, true);
@@ -60,7 +59,7 @@ protected JSCallGraph runTest(
 
   protected JSCallGraph runBoundedTest(
       String script, List<GraphAssertion> assertions, BuilderType builderType, int bound)
-      throws WalaException, Error, CancelException {
+      throws WalaException, CancelException {
     final JSCallGraph cg;
     JavaScriptLoaderFactory loaders = new JavaScriptLoaderFactory(new CAstRhinoTranslatorFactory());
     IProgressMonitor monitor = ProgressMaster.make(new NullProgressMonitor(), 45000, true);

cast/js/rhino/src/test/java/com/ibm/wala/cast/js/rhino/callgraph/fieldbased/test/AbstractFieldBasedTest.java

@@ -1,6 +1,5 @@
 package com.ibm.wala.cast.js.rhino.callgraph.fieldbased.test;
 
-import com.ibm.wala.cast.ir.translator.TranslatorToCAst.Error;
 import com.ibm.wala.cast.js.util.FieldBasedCGUtil.BuilderType;
 import com.ibm.wala.util.CancelException;
 import com.ibm.wala.util.WalaException;
@@ -18,7 +17,7 @@
 public class FieldBasedCGGamesTest extends AbstractFieldBasedTest {
 
   @Test
-  public void testBunnyHunt() throws IOException, WalaException, Error, CancelException {
+  public void testBunnyHunt() throws IOException, WalaException, CancelException {
     URL url = getUrl("http://www.themaninblue.com/experiment/BunnyHunt/");
     runTest(url, List.of(), BuilderType.OPTIMISTIC);
   }
@@ -33,21 +32,21 @@ private static URL getUrl(String urlStr) throws MalformedURLException {
 
   @Disabled("seems to break with http issues")
   @Test
-  public void testBeslimed() throws IOException, WalaException, Error, CancelException {
+  public void testBeslimed() throws IOException, WalaException, CancelException {
     URL url = getUrl("http://www.markus-inger.de/test/game.php");
     runTest(url, List.of(), BuilderType.OPTIMISTIC);
   }
 
   @Disabled("seems to break with http issues")
   @Test
-  public void testDiggAttack() throws IOException, WalaException, Error, CancelException {
+  public void testDiggAttack() throws IOException, WalaException, CancelException {
     URL url = getUrl("http://www.pixastic.com/labs/digg_attack/");
     runTest(url, List.of(), BuilderType.OPTIMISTIC);
   }
 
   @Disabled
   @Test
-  public void testRiverRaider() throws IOException, WalaException, Error, CancelException {
+  public void testRiverRaider() throws IOException, WalaException, CancelException {
     URL url =
         getUrl(
             "http://playstar.mobi/games/riverraider/index.html?playerId=&gameId=8&highscore=102425");
@@ -56,31 +55,31 @@ public void testRiverRaider() throws IOException, WalaException, Error, CancelEx
 
   @Disabled("fails with \"timed out\" CancelException")
   @Test
-  public void testSolitaire() throws IOException, WalaException, Error, CancelException {
+  public void testSolitaire() throws IOException, WalaException, CancelException {
     URL url = getUrl("http://www.inmensia.com/files/solitaire1.0.html");
     runTest(url, List.of(), BuilderType.OPTIMISTIC);
   }
 
   @Test // (expected = CancelException.class)
-  public void testWorldOfSolitaire() throws IOException, WalaException, Error, CancelException {
+  public void testWorldOfSolitaire() throws IOException, WalaException, CancelException {
     URL url = getUrl("http://worldofsolitaire.com/");
     runTest(url, List.of(), BuilderType.OPTIMISTIC);
   }
 
   @Test
-  public void testMinesweeper() throws IOException, WalaException, Error, CancelException {
+  public void testMinesweeper() throws IOException, WalaException, CancelException {
     URL url = getUrl("http://www.inmensia.com/files/minesweeper1.0.html");
     runTest(url, List.of(), BuilderType.OPTIMISTIC_WORKLIST);
   }
 
   @Test
-  public void testProtoRPG() throws IOException, WalaException, Error, CancelException {
+  public void testProtoRPG() throws IOException, WalaException, CancelException {
     URL url = getUrl("http://www.protorpg.com/games/protorpg/?game=prologue");
     runTest(url, List.of(), BuilderType.OPTIMISTIC_WORKLIST);
   }
 
   @Test
-  public void testBattleship() throws IOException, WalaException, Error, CancelException {
+  public void testBattleship() throws IOException, WalaException, CancelException {
     URL url = getUrl("http://www.sinkmyship.com/battleship/single.html");
     runTest(url, List.of(), BuilderType.OPTIMISTIC_WORKLIST);
   }

cast/js/rhino/src/test/java/com/ibm/wala/cast/js/rhino/callgraph/fieldbased/test/FieldBasedCGGamesTest.java

@@ -2,7 +2,6 @@
 
 import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
 
-import com.ibm.wala.cast.ir.translator.TranslatorToCAst.Error;
 import com.ibm.wala.cast.js.test.ExtractingToPredictableFileNames;
 import com.ibm.wala.cast.js.test.TestSimplePageCallGraphShape;
 import com.ibm.wala.cast.js.util.FieldBasedCGUtil.BuilderType;
@@ -14,7 +13,7 @@
 public class FieldBasedComparisonTest extends AbstractFieldBasedTest {
 
   private void test(String file, List<GraphAssertion> assertions, BuilderType builderType)
-      throws WalaException, Error, CancelException {
+      throws WalaException, CancelException {
     try (ExtractingToPredictableFileNames predictable = new ExtractingToPredictableFileNames()) {
       runTest(file, assertions, builderType);
     }
@@ -32,15 +31,15 @@ public void testSkeletonPessimistic() {
   }
 
   @Test
-  public void testSkeletonOptimistic() throws WalaException, Error, CancelException {
+  public void testSkeletonOptimistic() throws WalaException, CancelException {
     test(
         "pages/skeleton.html",
         TestSimplePageCallGraphShape.assertionsForSkeleton,
         BuilderType.OPTIMISTIC);
   }
 
   @Test
-  public void testSkeletonWorklist() throws WalaException, Error, CancelException {
+  public void testSkeletonWorklist() throws WalaException, CancelException {
     test(
         "pages/skeleton.html",
         TestSimplePageCallGraphShape.assertionsForSkeleton,
@@ -59,15 +58,15 @@ public void testSkeleton2Pessimistic() {
   }
 
   @Test
-  public void testSkeleton2Optimistic() throws WalaException, Error, CancelException {
+  public void testSkeleton2Optimistic() throws WalaException, CancelException {
     test(
         "pages/skeleton2.html",
         TestSimplePageCallGraphShape.assertionsForSkeleton2,
         BuilderType.OPTIMISTIC);
   }
 
   @Test
-  public void testSkeleton2Worklist() throws WalaException, Error, CancelException {
+  public void testSkeleton2Worklist() throws WalaException, CancelException {
     test(
         "pages/skeleton2.html",
         TestSimplePageCallGraphShape.assertionsForSkeleton2,

cast/js/rhino/src/test/java/com/ibm/wala/cast/js/rhino/callgraph/fieldbased/test/FieldBasedComparisonTest.java

@@ -1,6 +1,5 @@
 package com.ibm.wala.cast.js.rhino.callgraph.fieldbased.test;
 
-import com.ibm.wala.cast.ir.translator.TranslatorToCAst.Error;
 import com.ibm.wala.cast.js.util.FieldBasedCGUtil.BuilderType;
 import com.ibm.wala.util.CancelException;
 import com.ibm.wala.util.WalaException;
@@ -15,8 +14,7 @@
 public class FieldBasedJQueryTest extends AbstractFieldBasedTest {
 
   @Test
-  public void test1_8_2()
-      throws IOException, WalaException, Error, CancelException, URISyntaxException {
+  public void test1_8_2() throws IOException, WalaException, CancelException, URISyntaxException {
     runTest(
         new URI("http://code.jquery.com/jquery-1.8.2.js").toURL(),
         List.of(),

cast/js/rhino/src/test/java/com/ibm/wala/cast/js/rhino/callgraph/fieldbased/test/FieldBasedJQueryTest.java

@@ -10,7 +10,6 @@
  */
 package com.ibm.wala.cast.js.rhino.callgraph.fieldbased.test;
 
-import com.ibm.wala.cast.ir.translator.TranslatorToCAst.Error;
 import com.ibm.wala.cast.js.util.FieldBasedCGUtil.BuilderType;
 import com.ibm.wala.util.CancelException;
 import com.ibm.wala.util.WalaException;
@@ -26,7 +25,7 @@ public class TestBoundedFieldBasedCG extends AbstractFieldBasedTest {
           new GraphAssertion("suffix:call", new String[] {"!suffix:m"}));
 
   @Test
-  public void testBound0Worklist() throws WalaException, Error, CancelException {
+  public void testBound0Worklist() throws WalaException, CancelException {
     runBoundedTest(
         "tests/field-based/bounded.js", assertionsForBound0JS, BuilderType.OPTIMISTIC_WORKLIST, 0);
   }
@@ -39,7 +38,7 @@ public void testBound0Worklist() throws WalaException, Error, CancelException {
           new GraphAssertion("suffix:call", new String[] {"!suffix:m"}));
 
   @Test
-  public void testBound1Worklist() throws WalaException, Error, CancelException {
+  public void testBound1Worklist() throws WalaException, CancelException {
     runBoundedTest(
         "tests/field-based/bounded.js", assertionsForBound1JS, BuilderType.OPTIMISTIC_WORKLIST, 1);
   }
@@ -52,7 +51,7 @@ public void testBound1Worklist() throws WalaException, Error, CancelException {
           new GraphAssertion("suffix:call", new String[] {"suffix:m"}));
 
   @Test
-  public void testBound2Worklist() throws WalaException, Error, CancelException {
+  public void testBound2Worklist() throws WalaException, CancelException {
     runBoundedTest(
         "tests/field-based/bounded.js", assertionsForBound2JS, BuilderType.OPTIMISTIC_WORKLIST, 2);
   }