Merged
Conversation
Closed
|
You can find the image built from this PR at Built from d36d7e1 |
Ivansete-status
force-pushed
the
correct-shard-mod
branch
from
2e2ded2 to
6c05ed1
Compare
Ivansete-status
requested review from
NagyZoltanPeter,
SionoiS and
darshankabariya
darshankabariya
approved these changes
Aug 1, 2025
Contributor
darshankabariya
left a comment
darshankabariya
left a comment
There was a problem hiding this comment.
Amazing catch, Thanks @Ivansete-status. LGTM
NagyZoltanPeter
approved these changes
Aug 1, 2025
Contributor
NagyZoltanPeter
left a comment
NagyZoltanPeter
left a comment
There was a problem hiding this comment.
Amazing!
Actually the original only works for count that is power of two.
Btw, it is never a good idea to optimize a code this way. Trust the compiler it knows better.
If you check with compiler explorer the C code equivalent compiles exactly according to what compiler can predict. https://godbolt.org/z/f7MaKeKzG
So such a solution can only work if you are sure the count is always power of two.
Ivansete-status
added a commit
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It seems that the suggested operation is not equivalent for all cases.
For example, the following don't give the same results:
Issue