feat: libwaku dll for status go by darshankabariya · Pull Request #3460 · logos-messaging/logos-delivery

darshankabariya · 2025-06-19T09:13:23Z

Added support for building dynamic libraries (*.dll) on Windows systems.

Now, both libwaku.dll and wakunode2.exe can be generated using ./script/build_windows.sh.

Also added CI checks to verify the successful build of libwaku.dll.
@gabrielmer

github-actions · 2025-06-19T09:19:04Z

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3460

Built from 26fdbbf

Ivansete-status

Thanks for it!
Nevertheless, I think we need to double-check it :)
When trying to build on Ubuntu, I'm getting the following:

12:10:28 {libwaku_dll} ~/workspace/status/nwaku$ 
$  [Nimbus env]$ make libwaku -j8

Warning: to ensure you are building in a supported repo state, please always run "make update" after "git pull"
(it looks like you've forgotten to do this).
This also applies whenever you switch to a new branch or commit, e.g.: whenever you run "git checkout ...".

bash: -c: line 1: syntax error near unexpected token `Linux,Windows'
bash: -c: line 1: `ifeq (Linux,Windows)'
make: *** [Makefile:406: libwaku] Error 2

Cheers

Ivansete-status · 2025-06-19T10:06:57Z

scripts/build_wakunode_windows.sh

-execute_command "make wakunode2 LOG_LEVEL=DEBUG V=1 -j8"
+execute_command "make wakunode2 LOG_LEVEL=DEBUG V=1 -j"
+
+echo "9. -.-.-.- Building libwaku -.-.-.- "


Suggested change

echo "9. -.-.-.- Building libwaku -.-.-.- "

echo "10. -.-.-.- Building libwaku -.-.-.- "

Ivansete-status · 2025-06-19T10:11:20Z

waku.nimble

-    exec "nim c" & " --out:build/" & name &
-      ".so --threads:on --app:lib --opt:size --noMain --mm:refc --header -d:metrics --nimMainPrefix:libwaku --skipParentCfg:on -d:discv5_protocol_id=d5waku " &
-      extra_params & " " & srcDir & name & ".nim"
+    when defined(windows):


It seems the unix-based OSs are forgotten somehow

Ivansete-status · 2025-06-19T10:12:02Z

waku.nimble

-       --warning:Deprecated:off \
-       --warning:UnusedImport:on \
-       -d:chronicles_log_level=TRACE """,
+    """-d:chronicles_line_numbers -d:chronicles_runtime_filtering=on -d:chronicles_sinks="textlines,json" -d:chronicles_default_output_device=Dynamic -d:chronicles_disabled_topics="eth,dnsdisc.client" --warning:Deprecated:off --warning:UnusedImport:on -d:chronicles_log_level=TRACE """,


Let's keep it vertical :)
Easier to read and easier to see diffs on each line in future PRs
Also applicable to the next change

Thanks for comment @Ivansete-status, I’ve addressed all your comments.

I’m getting a unrealistic error with vertical param, I can’t debug yet, but I’m working on it.

@darshankabariya Isn't that because of the multiline string literal by """ - triple quote?

Yeah, it was a spacing issue. I’ve fixed it using string concatenation.

NagyZoltanPeter · 2025-06-19T22:10:57Z

Makefile

+else ifeq ($(detected_OS),Windows)
+	echo -e $(BUILD_MSG) "build/$@.dll" && $(ENV_SCRIPT) nim libwakuDLL $(NIM_PARAMS) waku.nims


I would rather make separation by target platfom in one place of possible.
For me it sounds that shouldn't be different command in the makefile to build dyn lib in different platforms.
I would move it to nimble better.
But maybe it is just my taste :-)

Got it. I wasn’t sure it would work without OS checks since we need to echo .dll or .so. But your idea helped — we can drop libwakuDLL, libwakuDynamic can handle both libs.

NagyZoltanPeter · 2025-06-19T22:23:21Z

waku.nimble

+  elif `type` == "dll":
+    exec "nim c" & " --out:build/" & name &
+      ".dll --nimcache:build/nimcache --threads:on --app:lib --opt:size --noMain --mm:refc --header -d:metrics --nimMainPrefix:libwaku -d:discv5_protocol_id=d5waku " &


nimscript has support for properly add extension to target filename:
toDll and toExe
https://github.com/nim-lang/Nim/blob/f7145dd26efeeeb6eeae6fff649db244d81b212d/lib/system/nimscript.nim#L147

Using these can simplify nimble code imho.
But beware toDll will result lib+name+ext... so maybe we need to replicate it for our purpose.

Thanks, @NagyZoltanPeter — I’ve addressed this suggestion.

NagyZoltanPeter · 2025-06-23T04:15:50Z

waku.nimble

+    var lib_name = toDll("libwaku")
+    when defined(windows):
+      exec "nim c" & " --out:build/" & lib_name &
+        ".so --threads:on --app:lib --opt:size --noMain --mm:refc --header -d:metrics --nimMainPrefix:libwaku --skipParentCfg:off -d:discv5_protocol_id=d5waku " &
+        extra_params & " " & srcDir & name & ".nim"
+    else:
+      exec "nim c" & " --out:build/" & lib_name &
+        ".so --threads:on --app:lib --opt:size --noMain --mm:refc --header -d:metrics --nimMainPrefix:libwaku --skipParentCfg:on -d:discv5_protocol_id=d5waku " &
+        extra_params & " " & srcDir & name & ".nim"


warn: Isn't toDll("libwaku") will return liblibwaku.so or liblibwaku.dll?
Well also if we still need to branch by platform due to --skipParentCfg... I'm questioning my original reasoning here. But it's hard to recognise at first sight. Btw, why is this distinction?

Thanks for pointing out the distinction with --skipParentCfg. On Windows, building the binary without external requirements is a bit tricky. Once we fully integrate windows support into the make command, we can revisit and properly address this. For now, I’ve removed --skipParentCfg specifically for the Windows build. cc (@NagyZoltanPeter)

NagyZoltanPeter

Thank you!!! Awesome!

gabrielmer

LGTM, thanks so much!

github-actions bot assigned darshankabariya Jun 19, 2025

Ivansete-status reviewed Jun 19, 2025

View reviewed changes

darshankabariya marked this pull request as draft June 19, 2025 11:19

darshankabariya requested review from Ivansete-status, NagyZoltanPeter and gabrielmer June 19, 2025 19:55

darshankabariya marked this pull request as ready for review June 19, 2025 19:59

NagyZoltanPeter reviewed Jun 19, 2025

View reviewed changes

darshankabariya force-pushed the libwaku_dll branch from 41b2f73 to 5737fa8 Compare June 20, 2025 05:52

darshankabariya added 6 commits June 20, 2025 18:02

fix: initial PR

2649918

fix: update according to different OS

e99e50a

fix: according to suggestion

92e6095

fix: according to suggestion

e9477e3

fix: vertical

571af96

fix: adding default

6c8630a

darshankabariya force-pushed the libwaku_dll branch 2 times, most recently from 916e2eb to 6c8630a Compare June 20, 2025 15:53

darshankabariya added 3 commits June 20, 2025 21:24

fix: extra thread

4fa7f92

fix: adding default

b40f31e

fix: suggestions

4288ac5

NagyZoltanPeter reviewed Jun 23, 2025

View reviewed changes

fix: update PR

a99716a

darshankabariya requested a review from NagyZoltanPeter June 23, 2025 12:11

fix: update PR

1041224

NagyZoltanPeter approved these changes Jun 24, 2025

View reviewed changes

darshankabariya force-pushed the libwaku_dll branch from b82ea5c to 1041224 Compare June 24, 2025 08:49

gabrielmer approved these changes Jun 24, 2025

View reviewed changes

Merge branch 'master' into libwaku_dll

87ec8d6

darshankabariya merged commit 8a905a5 into master Jun 25, 2025
8 of 9 checks passed

darshankabariya deleted the libwaku_dll branch June 25, 2025 19:33

Ivansete-status pushed a commit that referenced this pull request Jan 28, 2026

feat: libwaku dll for status go (#3460)

5c38a53

	echo "9. -.-.-.- Building libwaku -.-.-.- "
	echo "10. -.-.-.- Building libwaku -.-.-.- "

		else ifeq ($(detected_OS),Windows)
		echo -e $(BUILD_MSG) "build/$@.dll" && $(ENV_SCRIPT) nim libwakuDLL $(NIM_PARAMS) waku.nims

Conversation

darshankabariya commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ivansete-status left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

darshankabariya Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NagyZoltanPeter left a comment

Choose a reason for hiding this comment

Uh oh!

gabrielmer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

darshankabariya commented Jun 19, 2025 •

edited

Loading

github-actions bot commented Jun 19, 2025 •

edited

Loading

darshankabariya Jun 19, 2025 •

edited

Loading