Skip to content

Commit 3cb8ebd

Browse files
refactor(libwaku): allow several multiaddresses for a single peer in store queries (#3171)
* fix: parameter name * refactor: allow multiple addresses for a peer in a store query
1 parent 8fde709 commit 3cb8ebd

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

library/libwaku.nim

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -710,7 +710,7 @@ proc waku_peer_exchange_request(
710710

711711
proc waku_ping_peer(
712712
ctx: ptr WakuContext,
713-
peerID: cstring,
713+
peerAddr: cstring,
714714
timeoutMs: cuint,
715715
callback: WakuCallBack,
716716
userData: pointer,
@@ -721,7 +721,7 @@ proc waku_ping_peer(
721721
.sendRequestToWakuThread(
722722
ctx,
723723
RequestType.PING,
724-
PingRequest.createShared(peerID, chronos.milliseconds(timeoutMs)),
724+
PingRequest.createShared(peerAddr, chronos.milliseconds(timeoutMs)),
725725
)
726726
.handleRes(callback, userData)
727727

library/waku_thread/inter_thread_communication/requests/protocols/store_request.nim

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import std/[json, sugar, options]
1+
import std/[json, sugar, strutils, options]
22
import chronos, chronicles, results
33
import
44
../../../../../waku/factory/waku,
@@ -125,7 +125,7 @@ proc process(
125125

126126
let storeQueryRequest = JsonStoreQueryRequest.fromJsonNode(jsonContentRes.get())
127127

128-
let peer = peers.parsePeerInfo($self[].peerAddr).valueOr:
128+
let peer = peers.parsePeerInfo(($self[].peerAddr).split(",")).valueOr:
129129
return err("JsonStoreQueryRequest failed to parse peer addr: " & $error)
130130

131131
let queryResponse = (await waku.node.wakuStoreClient.query(storeQueryRequest, peer)).valueOr:

0 commit comments

Comments
 (0)