Commit f66281d
Richard Wheeler
net.quic: 13a - correct an overclaimed doc comment
encode_certificate_verify's doc comment stated as settled fact that its
OpenSSL-produced DER signature is directly compatible with net.mbedtls's
verify_ecdsa_signature ("no reformatting needed between the two
libraries"). That's the expected, standard behavior (OpenSSL's default EC
signing format and mbedTLS's ECDSA verification both use ASN.1 DER
ECDSA-Sig-Value, the TLS/X.509 convention), but this repo has never
actually tested it: there's no EC certificate fixture to build an
mbedtls_pk_context from for a real cross-library check, only a same-library
(OpenSSL signs, OpenSSL verifies) round trip. Reworded to state what's
actually verified (source inspection + the same-library test) versus what's
expected-but-untested, rather than asserting settled fact.
Caught during a requested pass verifying claims made across this PR's
commits/comments. Everything else checked (RSA-PSS signing wrapper
non-existence, EC certificate fixture non-existence, the three distinct
key_share wire shapes, the supported_versions client/server asymmetry, and
the application-secrets-derive-after-server-Finished timing) was confirmed
accurate against the cached primary RFC text directly.1 parent 01f7548 commit f66281d
1 file changed
Lines changed: 11 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
299 | 299 | | |
300 | 300 | | |
301 | 301 | | |
302 | | - | |
303 | | - | |
304 | | - | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
305 | 313 | | |
306 | 314 | | |
307 | 315 | | |
| |||
0 commit comments