v3: fix post-merge CI regressions

Author: medvednikov

vlib/v3/tests/review_transform_regressions_test.v

@@ -5460,7 +5460,7 @@ fn main() {
 	println(value.str())
 }
 ')
-	assert out == 'alpha'
+	assert out == '&alpha'
 }
 
 fn test_struct_literal_implicit_reference_and_option_or_mut_receiver() {

vlib/v3/tests/veb_html_dynamic_path_codegen_test.v

@@ -38,7 +38,7 @@ fn test_veb_html_dynamic_path_is_rejected_not_handler_template() {
 	os.write_file(os.join_path(root, 'dyn.v'), vhd_app_source('\$veb.html(name)')) or { panic(err) }
 	dyn_c := os.join_path(root, 'dyn.c')
 	os.rm(dyn_c) or {}
-	dyn := os.execute('${v3_bin} ${os.join_path(root, 'dyn.v')} -o ${dyn_c}')
+	dyn := os.execute('${v3_bin} -no-memory-limit ${os.join_path(root, 'dyn.v')} -o ${dyn_c}')
 	assert dyn.exit_code != 0, 'a non-compile-time `\$veb.html(path)` must be rejected, got:\n${dyn.output}'
 	dyn_code := os.read_file(dyn_c) or { '' }
 	assert !dyn_code.contains('HANDLER_TEMPLATE'), 'dynamic path must not resolve to the handler template'
@@ -47,7 +47,7 @@ fn test_veb_html_dynamic_path_is_rejected_not_handler_template() {
 	os.write_file(os.join_path(root, 'noarg.v'), vhd_app_source('\$veb.html()')) or { panic(err) }
 	noarg_c := os.join_path(root, 'noarg.c')
 	os.rm(noarg_c) or {}
-	noarg := os.execute('${v3_bin} ${os.join_path(root, 'noarg.v')} -o ${noarg_c}')
+	noarg := os.execute('${v3_bin} -no-memory-limit ${os.join_path(root, 'noarg.v')} -o ${noarg_c}')
 	assert noarg.exit_code == 0, noarg.output
 	noarg_code := os.read_file(noarg_c) or { '' }
 	assert noarg_code.contains('HANDLER_TEMPLATE'), 'the no-arg form should render the handler template'

vlib/v3/tests/veb_html_requires_call_codegen_test.v

@@ -38,7 +38,7 @@ fn test_veb_html_requires_call_syntax() {
 	os.write_file(os.join_path(root, 'ok.v'), vhrc_app_source('\$veb.html()')) or { panic(err) }
 	ok_c := os.join_path(root, 'ok.c')
 	os.rm(ok_c) or {}
-	ok := os.execute('${v3_bin} ${os.join_path(root, 'ok.v')} -o ${ok_c}')
+	ok := os.execute('${v3_bin} -no-memory-limit ${os.join_path(root, 'ok.v')} -o ${ok_c}')
 	assert ok.exit_code == 0, ok.output
 	ok_code := os.read_file(ok_c) or { '' }
 	assert ok_code.contains('HELLO_TMPL'), 'the call form should render the handler template'
@@ -47,7 +47,7 @@ fn test_veb_html_requires_call_syntax() {
 	os.write_file(os.join_path(root, 'bad.v'), vhrc_app_source('\$veb.html')) or { panic(err) }
 	bad_c := os.join_path(root, 'bad.c')
 	os.rm(bad_c) or {}
-	bad := os.execute('${v3_bin} ${os.join_path(root, 'bad.v')} -o ${bad_c}')
+	bad := os.execute('${v3_bin} -no-memory-limit ${os.join_path(root, 'bad.v')} -o ${bad_c}')
 	assert bad.exit_code != 0, 'bare `\$veb.html` without a call must be rejected, got:\n${bad.output}'
 	bad_code := os.read_file(bad_c) or { '' }
 	assert !bad_code.contains('HELLO_TMPL'), 'bare `\$veb.html` must not render the handler template'

vlib/v3/transform/array.v

@@ -94,9 +94,9 @@ fn (mut t Transformer) try_lower_array_repeat_call(_id flat.NodeId, node flat.No
 	return t.make_call_expr_typed(selector, [count, t.make_int_literal(depth)], node.typ)
 }
 
-// make_plain_array_repeat_value preserves the repeated result before destroying a
-// non-addressable source array whose backing storage was materialized after ownership
-// analysis.
+// make_plain_array_repeat_value preserves the repeated result before freeing the backing
+// storage of a non-addressable source array materialized after ownership analysis. The
+// repeated result owns the shallow-copied elements, so the source elements must not be dropped.
 fn (mut t Transformer) make_plain_array_repeat_value(base_id flat.NodeId, count_id flat.NodeId, array_type string) flat.NodeId {
 	source := t.transform_expr(base_id)
 	stable_source := t.stable_transformed_expr_for_reuse(source, array_type,
@@ -108,9 +108,7 @@ fn (mut t Transformer) make_plain_array_repeat_value(base_id flat.NodeId, count_
 		array_type)
 	out_name := t.new_temp('plain_array_repeat')
 	t.pending_stmts << t.make_decl_assign_typed(out_name, repeated, array_type)
-	t.pending_stmts << t.make_expr_stmt(t.make_call_typed('drop_owned', [
-		stable_source,
-	], 'void'))
+	t.pending_stmts << t.make_expr_stmt(t.make_method_call(stable_source, 'free', []flat.NodeId{}))
 	result := t.make_ident(out_name)
 	t.set_node_typ(int(result), array_type)
 	return result

vlib/v3/transform/monomorphize.v

@@ -9592,6 +9592,9 @@ fn (mut t Transformer) generic_comptime_typeof_target(node flat.Node, args []str
 		}
 	}
 	target := t.generic_comptime_base_type(child_id, args) or { return none }
+	if child.kind == .ident && t.mut_param_values[child.value] && !target.starts_with('&') {
+		return '&${target}'
+	}
 	return target
 }