Cleanup TODOs targeting v25 or earlier (#20048)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

Author: timvaillancourt

changelog/25.0/25.0.0/summary.md

@@ -7,6 +7,9 @@
 - **[Major Changes](#major-changes)**
     - **[New Support](#new-support)**
     - **[Breaking Changes](#breaking-changes)**
+        - [`--watch-replication-stream` flag removed](#vttablet-watch-replication-stream-removed)
+        - [Snapshot Topology feature removed](#vtorc-snapshot-topology-removed)
+        - [VTOrc `--cell` flag is now required](#vtorc-cell-required)
 - **[Minor Changes](#minor-changes)**
     - **[VReplication](#minor-changes-vreplication)**
         - [Default data protection for `_reverse` workflow cancel/complete](#vreplication-reverse-workflow-data-protection)
@@ -23,6 +26,36 @@
 
 ### <a id="breaking-changes"/>Breaking Changes</a>
 
+#### <a id="vttablet-watch-replication-stream-removed"/>`--watch-replication-stream` flag removed</a>
+
+The deprecated `--watch-replication-stream` VTTablet flag has been removed.
+
+**Migration**: remove `--watch-replication-stream` from VTTablet startup arguments.
+
+**Impact**: VTTablet will fail to start if `--watch-replication-stream` is still passed.
+
+See [#20048](https://github.com/vitessio/vitess/pull/20048) for the removal and [#19204](https://github.com/vitessio/vitess/pull/19204) for the original deprecation.
+
+#### <a id="vtorc-snapshot-topology-removed"/>Snapshot Topology feature removed</a>
+
+VTOrc's Snapshot Topology feature, [deprecated in v24](../../24.0/24.0.0/summary.md#vtorc-snapshot-topology-deprecation), has been removed. This includes the `--snapshot-topology-interval` flag and the `database_instance_topology_history` table.
+
+**Migration**: remove `--snapshot-topology-interval` from VTOrc startup arguments.
+
+**Impact**: VTOrc will fail to start if `--snapshot-topology-interval` is still passed.
+
+See [#20048](https://github.com/vitessio/vitess/pull/20048) for the removal and [#19070](https://github.com/vitessio/vitess/pull/19070) for the original deprecation.
+
+#### <a id="vtorc-cell-required"/>VTOrc `--cell` flag is now required</a>
+
+The `--cell` VTOrc flag, [introduced in v24](../../24.0/24.0.0/summary.md#vtorc-cell-flag), is now required.
+
+**Migration**: ensure `--cell` is set on every VTOrc deployment.
+
+**Impact**: VTOrc will fail to start with a `FAILED_PRECONDITION` error if `--cell` is empty.
+
+See [#20048](https://github.com/vitessio/vitess/pull/20048) for the removal and [#19047](https://github.com/vitessio/vitess/pull/19047) for the original `--cell` flag introduction.
+
 ## <a id="minor-changes"/>Minor Changes</a>
 
 #### <a id="vreplication-reverse-workflow-data-protection"/>Default data protection for `_reverse` workflow cancel/complete</a>

config/tablet/default.yaml

@@ -100,7 +100,6 @@ consolidator: enable|disable|notOnPrimary # enable-consolidator, enable-consolid
 passthroughDML: false                    # queryserver-config-passthrough-dmls
 streamBufferSize: 32768                  # queryserver-config-stream-buffer-size
 schemaReloadIntervalSeconds: 1800        # queryserver-config-schema-reload-time
-watchReplication: false                  # watch-replication-stream
 terseErrors: false                       # queryserver-config-terse-errors
 truncateErrorLen: 0                      # queryserver-config-truncate-error-len
 messagePostponeParallelism: 4            # queryserver-config-message-postpone-cap

doc/design-docs/TabletServerParamsAsYAML.md

@@ -127,7 +127,6 @@ shutdownGracePeriodSeconds: 0            # transaction_shutdown_grace_period
 passthroughDML: false                    # queryserver-config-passthrough-dmls
 streamBufferSize: 32768                  # queryserver-config-stream-buffer-size
 schemaReloadIntervalSeconds: 1800        # queryserver-config-schema-reload-time
-watchReplication: false                  # watch_replication_stream
 terseErrors: false                       # queryserver-config-terse-errors
 messagePostponeParallelism: 4            # queryserver-config-message-postpone-cap
 sanitizeLogMessages: false               # sanitize_log_messages

examples/common/vtorc/config.yaml

@@ -1,6 +1,5 @@
 instance-poll-time: 1s
 prevent-cross-cell-failover: false
-snapshot-topology-interval: 0h
 reasonable-replication-lag: 10s
 audit-to-backend: false
 audit-to-syslog: false

examples/operator/101_initial_cluster.yaml

@@ -90,6 +90,7 @@ spec:
           cpu: 100m
           memory: 128Mi
       extraFlags:
+        cell: zone1
         instance-poll-time: 1s
         log-format: text
     partitionings:

examples/operator/201_customer_tablets.yaml

@@ -86,6 +86,7 @@ spec:
           cpu: 100m
           memory: 128Mi
       extraFlags:
+        cell: zone1
         instance-poll-time: 1s
         log-format: text
     partitionings:
@@ -124,6 +125,9 @@ spec:
   - name: customer
     durabilityPolicy: none
     turndownPolicy: Immediate
+    vitessOrchestrator:
+      extraFlags:
+        cell: zone1
     partitionings:
     - equal:
         parts: 1

examples/operator/302_new_shards.yaml

@@ -86,6 +86,7 @@ spec:
           cpu: 100m
           memory: 128Mi
       extraFlags:
+        cell: zone1
         instance-poll-time: 1s
         log-format: text
     partitionings:
@@ -124,6 +125,9 @@ spec:
   - name: customer
     durabilityPolicy: none
     turndownPolicy: Immediate
+    vitessOrchestrator:
+      extraFlags:
+        cell: zone1
     partitionings:
     - equal:
         parts: 1

examples/operator/306_down_shard_0.yaml

@@ -86,6 +86,7 @@ spec:
           cpu: 100m
           memory: 128Mi
       extraFlags:
+        cell: zone1
         instance-poll-time: 1s
         log-format: text
     partitionings:
@@ -124,6 +125,9 @@ spec:
   - name: customer
     durabilityPolicy: none
     turndownPolicy: Immediate
+    vitessOrchestrator:
+      extraFlags:
+        cell: zone1
     partitionings:
     - equal:
         parts: 2

examples/operator/401_scheduled_backups.yaml

@@ -120,6 +120,7 @@ spec:
           cpu: 100m
           memory: 128Mi
       extraFlags:
+        cell: zone1
         instance-poll-time: 1s
         log-format: text
     partitionings:
@@ -159,6 +160,9 @@ spec:
   - name: customer
     durabilityPolicy: none
     turndownPolicy: Immediate
+    vitessOrchestrator:
+      extraFlags:
+        cell: zone1
     partitionings:
     - equal:
         parts: 2

go/flags/endtoend/vtorc.txt

@@ -25,7 +25,7 @@ Flags:
       --backend-write-concurrency int                               Maximum concurrency for writes to the backend (default 24)
       --bind-address string                                         Bind address for the server. If empty, the server will listen on all available unicast and anycast IP addresses of the local system.
       --catch-sigpipe                                               catch and ignore SIGPIPE on stdout and stderr if specified
-      --cell string                                                 cell to use (required in v25+)
+      --cell string                                                 cell to use (required)
       --cells-to-watch strings                                      Comma-separated list of cells that this instance will monitor and repair. Defaults to all cells in the topology. Example: "cell1,cell2"
       --change-tablets-with-errant-gtid-to-drained                  Whether VTOrc should be changing the type of tablets with errant GTIDs to DRAINED
       --clusters-to-watch strings                                   Comma-separated list of keyspaces or keyspace/keyranges that this instance will monitor and repair. Defaults to all clusters in the topology. Example: "ks1,ks2/-80"
@@ -74,7 +74,6 @@ Flags:
       --remote-operation-timeout duration                           time to wait for a remote operation (default 15s)
       --security-policy string                                      the name of a registered security policy to use for controlling access to URLs - empty means allow all for anyone (built-in policies: deny-all, read-only)
       --shutdown-wait-time duration                                 Maximum time to wait for VTOrc to release all the locks that it is holding before shutting down on SIGTERM (default 30s)
-      --snapshot-topology-interval duration                         Timer duration on which VTOrc takes a snapshot of the current MySQL information it has in the database. Should be in multiple of hours
       --sqlite-data-file string                                     SQLite Datafile to use as VTOrc's database (default "file::memory:?mode=memory&cache=shared")
       --stats-backend string                                        The name of the registered push-based monitoring/stats backend to use
       --stats-combine-dimensions string                             List of dimensions to be combined into a single "all" value in exported stats vars