Skip to content

Commit a3ea8b7

Browse files
authored
k8stopo: Include deprecation warning (#13299)
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
1 parent 6c0de82 commit a3ea8b7

3 files changed

Lines changed: 13 additions & 1 deletion

File tree

changelog/17.0/17.0.0/release_notes.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
- **[Deprecations and Deletions](#deprecations-and-deletions)**
3636
- [Deprecated Flags](#deprecated-flags)
3737
- [Deprecated Stats](#deprecated-stats)
38+
- [`k8stopo` deprecated](#deprecated-k8stopo)
3839

3940

4041
## <a id="major-changes"/>Major Changes
@@ -451,10 +452,13 @@ These stats are deprecated in v17.
451452
| `backup_duration_seconds` | `BackupDurationNanoseconds` |
452453
| `restore_duration_seconds` | `RestoreDurationNanoseconds` |
453454

455+
#### <a id="deprecated-k8stopo"/>Deprecated `k8stopo`
456+
457+
The `k8stopo` has been deprecated, also see https://github.com/vitessio/vitess/issues/13298. With Vitess 18 the `k8stopo` will be removed.
458+
454459
------------
455460
The entire changelog for this release can be found [here](https://github.com/vitessio/vitess/blob/main/changelog/17.0/17.0.0/changelog.md).
456461

457462
The release includes 432 commits (excluding merges)
458463

459464
Thanks to all our contributors: @Ayman161803, @GuptaManan100, @L3o-pold, @Phanatic, @WilliamLu99, @adsr, @ajm188, @andylim-duo, @arthurschreiber, @austenLacy, @cuishuang, @dasl-, @dbussink, @deepthi, @dependabot[bot], @ejortegau, @fatih, @frouioui, @github-actions[bot], @harshit-gangal, @hkdsun, @jeremycole, @jhump, @johanstenberg92, @jwangace, @kevinpurwito, @kovyrin, @lixin963, @mattlord, @maxbrunet, @maxenglander, @mdlayher, @moberghammer, @notfelineit, @olyazavr, @pbibra, @pnacht, @rohit-nayak-ps, @rsajwani, @shlomi-noach, @systay, @timvaillancourt, @twthorn, @vbalys, @vinimdocarmo, @vitess-bot[bot], @vmg, @yoheimuta
460-

changelog/17.0/17.0.0/summary.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
- **[Deprecations and Deletions](#deprecations-and-deletions)**
3535
- [Deprecated Flags](#deprecated-flags)
3636
- [Deprecated Stats](#deprecated-stats)
37+
- [Deprecated `k8stopo`](#deprecated-k8stopo)
3738

3839

3940
## <a id="major-changes"/>Major Changes
@@ -449,3 +450,7 @@ These stats are deprecated in v17.
449450
|-|-|
450451
| `backup_duration_seconds` | `BackupDurationNanoseconds` |
451452
| `restore_duration_seconds` | `RestoreDurationNanoseconds` |
453+
454+
#### <a id="deprecated-k8stopo"/>Deprecated `k8stopo`
455+
456+
The `k8stopo` has been deprecated, also see https://github.com/vitessio/vitess/issues/13298. With Vitess 18 the `k8stopo` will be removed.

go/vt/topo/server.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,9 @@ func OpenServer(implementation, serverAddress, root string) (*Server, error) {
240240
// Open returns a Server using the command line parameter flags
241241
// for implementation, address and root. It log.Exits out if an error occurs.
242242
func Open() *Server {
243+
if topoImplementation == "k8s" {
244+
log.Warningf("The `k8stopo` is deprecated. We recommend using the `etcd2topo` instead. The `k8stopo` will be removed in Vitess 18.")
245+
}
243246
if topoGlobalServerAddress == "" && topoImplementation != "k8s" {
244247
log.Exitf("topo_global_server_address must be configured")
245248
}

0 commit comments

Comments
 (0)