ci: add per-step timeouts to fail fast on apt/registry hangs (#20031)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>

Author: arthurschreiber

.github/workflows/check_make_vtadmin_authz_testgen.yml

@@ -50,6 +50,7 @@ jobs:
 
     - name: Tune the OS
       if: steps.changes.outputs.vtadmin_changes == 'true'
+      timeout-minutes: 5
       uses: ./.github/actions/tune-os
 
     - name: Set up Go
@@ -61,6 +62,7 @@ jobs:
 
     - name: Get dependencies
       if: steps.changes.outputs.vtadmin_changes == 'true'
+      timeout-minutes: 5
       run: |
         sudo apt-get update
         sudo apt-get install -y make unzip g++ etcd-client etcd-server curl git wget
@@ -70,6 +72,7 @@ jobs:
 
     - name: Run make minimaltools
       if: steps.changes.outputs.vtadmin_changes == 'true'
+      timeout-minutes: 5
       run: |
         make minimaltools
 

.github/workflows/check_make_vtadmin_web_proto.yml

@@ -33,6 +33,7 @@ jobs:
         persist-credentials: 'false'
 
     - name: Tune the OS
+      timeout-minutes: 5
       uses: ./.github/actions/tune-os
 
     - name: Check for changes in relevant files

.github/workflows/cluster_endtoend.yml

@@ -138,20 +138,24 @@ jobs:
 
       - name: Tune the OS
         if: steps.changes.outputs.end_to_end == 'true'
+        timeout-minutes: 5
         uses: ./.github/actions/tune-os
 
       - name: Setup MySQL
         if: steps.changes.outputs.end_to_end == 'true' && !contains(matrix.needs, 'xtrabackup')
+        timeout-minutes: 8
         uses: ./.github/actions/setup-mysql
         with:
           flavor: mysql-8.4
 
       - name: Setup Percona Apt repository
         if: steps.changes.outputs.end_to_end == 'true' && contains(matrix.needs, 'xtrabackup')
+        timeout-minutes: 5
         uses: ./.github/actions/setup-percona-repo
 
       - name: Setup Percona Server and XtraBackup
         if: steps.changes.outputs.end_to_end == 'true' && contains(matrix.needs, 'xtrabackup')
+        timeout-minutes: 5
         run: |
           sudo percona-release setup pdps8.0
           sudo percona-release setup pxb-80
@@ -178,10 +182,12 @@ jobs:
 
       - name: Install Minio
         if: steps.changes.outputs.end_to_end == 'true' && contains(matrix.needs, 'minio')
+        timeout-minutes: 5
         uses: ./.github/actions/setup-minio
 
       - name: Install Consul and ZooKeeper
         if: steps.changes.outputs.end_to_end == 'true' && contains(matrix.needs, 'consul')
+        timeout-minutes: 5
         run: make BUILD_PROTOC=0 tools
 
       - name: Setup launchable dependencies

.github/workflows/codecov.yml

@@ -111,16 +111,19 @@ jobs:
 
     - name: Tune the OS
       if: steps.mode.outputs.is_full_run == 'true' || (steps.changes.outputs.changed_files == 'true' && steps.packages.outputs.packages != '')
+      timeout-minutes: 5
       uses: ./.github/actions/tune-os
 
     - name: Setup MySQL
       if: steps.mode.outputs.is_full_run == 'true' || (steps.changes.outputs.changed_files == 'true' && steps.packages.outputs.packages != '')
+      timeout-minutes: 8
       uses: ./.github/actions/setup-mysql
       with:
         flavor: mysql-8.4
 
     - name: Get dependencies
       if: steps.mode.outputs.is_full_run == 'true' || (steps.changes.outputs.changed_files == 'true' && steps.packages.outputs.packages != '')
+      timeout-minutes: 5
       run: |
         export DEBIAN_FRONTEND="noninteractive"
         sudo apt-get update
@@ -132,6 +135,7 @@ jobs:
 
     - name: Run make tools
       if: steps.mode.outputs.is_full_run == 'true' || (steps.changes.outputs.changed_files == 'true' && steps.packages.outputs.packages != '')
+      timeout-minutes: 10
       run: |
         make BUILD_JAVA=0 BUILD_PROTOC=0 tools
 

.github/workflows/codeql_analysis.yml

@@ -43,10 +43,12 @@ jobs:
           cache: ${{ (github.base_ref == 'main' || (github.base_ref == '' && github.ref_name == 'main')) && 'true' || 'false' }}
 
       - name: Tune the OS
+        timeout-minutes: 5
         uses: ./.github/actions/tune-os
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
+        timeout-minutes: 5
         uses: github/codeql-action/init@c10b8064de6f491fea524254123dbe5e09572f13 # v4.35.1
         with:
           languages: ${{ matrix.language }}
@@ -58,6 +60,7 @@ jobs:
           # queries: security-extended,security-and-quality
 
       - name: Setup MySQL
+        timeout-minutes: 8
         uses: ./.github/actions/setup-mysql
         with:
           flavor: mysql-8.4
@@ -79,6 +82,7 @@ jobs:
           make build
 
       - name: Perform CodeQL Analysis
+        timeout-minutes: 15
         uses: github/codeql-action/analyze@c10b8064de6f491fea524254123dbe5e09572f13 # v4.35.1
 
       - name: Slack Workflow Notification

.github/workflows/create_release.yml

@@ -35,9 +35,11 @@ jobs:
         cache: 'false'
 
     - name: Tune the OS
+      timeout-minutes: 5
       uses: ./.github/actions/tune-os
 
     - name: Get dependencies
+      timeout-minutes: 5
       run: |
         sudo apt-get update
         sudo apt-get install -y make ruby ruby-dev

.github/workflows/docker_build_images.yml

@@ -47,6 +47,7 @@ jobs:
 
       - name: Build and push on main
         if: startsWith(github.ref, 'refs/tags/') == false
+        timeout-minutes: 15
         uses: docker/build-push-action@bcafcacb16a39f128d818304e6c9c0c18556b85f # v7.1.0
         with:
           context: .
@@ -68,6 +69,7 @@ jobs:
 
       - name: Build and push on tags
         if: startsWith(github.ref, 'refs/tags/')
+        timeout-minutes: 15
         uses: docker/build-push-action@bcafcacb16a39f128d818304e6c9c0c18556b85f # v7.1.0
         with:
           context: .
@@ -107,6 +109,7 @@ jobs:
 
       - name: Build and push on main
         if: startsWith(github.ref, 'refs/tags/') == false
+        timeout-minutes: 15
         uses: docker/build-push-action@bcafcacb16a39f128d818304e6c9c0c18556b85f # v7.1.0
         with:
           context: .
@@ -132,6 +135,7 @@ jobs:
 
       - name: Build and push on tags
         if: startsWith(github.ref, 'refs/tags/')
+        timeout-minutes: 15
         uses: docker/build-push-action@bcafcacb16a39f128d818304e6c9c0c18556b85f # v7.1.0
         with:
           context: .
@@ -170,6 +174,7 @@ jobs:
 
       - name: Build and push on main latest tag
         if: startsWith(github.ref, 'refs/tags/') == false && matrix.debian == 'bookworm'
+        timeout-minutes: 15
         uses: docker/build-push-action@bcafcacb16a39f128d818304e6c9c0c18556b85f # v7.1.0
         with:
           context: ${{ env.DOCKER_CTX }}
@@ -181,6 +186,7 @@ jobs:
 
       - name: Build and push on main debian specific tag
         if: startsWith(github.ref, 'refs/tags/') == false
+        timeout-minutes: 15
         uses: docker/build-push-action@bcafcacb16a39f128d818304e6c9c0c18556b85f # v7.1.0
         with:
           context: ${{ env.DOCKER_CTX }}
@@ -213,6 +219,7 @@ jobs:
       # Build and Push component image to DOCKER_TAG, applies to both debian version
       - name: Build and push on tags using Debian extension
         if: startsWith(github.ref, 'refs/tags/')
+        timeout-minutes: 15
         uses: docker/build-push-action@bcafcacb16a39f128d818304e6c9c0c18556b85f # v7.1.0
         with:
           context: ${{ env.DOCKER_CTX }}
@@ -226,6 +233,7 @@ jobs:
       # It is fine to build a second time here when "matrix.debian == 'bookworm'" as we have cached the first build already
       - name: Build and push on tags without Debian extension
         if: startsWith(github.ref, 'refs/tags/') && matrix.debian == 'bookworm'
+        timeout-minutes: 15
         uses: docker/build-push-action@bcafcacb16a39f128d818304e6c9c0c18556b85f # v7.1.0
         with:
           context: ${{ env.DOCKER_CTX }}

.github/workflows/docker_ci.yml

@@ -69,6 +69,7 @@ jobs:
 
       - name: Build bootstrap images
         if: steps.changes.outputs.end_to_end == 'true'
+        timeout-minutes: 15
         uses: ./.github/actions/build-bootstrap
         with:
           bootstrap-version: ${{ env.BOOTSTRAP_VERSION }}
@@ -83,9 +84,11 @@ jobs:
 
       - name: Tune the OS
         if: steps.changes.outputs.end_to_end == 'true'
+        timeout-minutes: 5
         uses: ./.github/actions/tune-os
 
       - name: Run docker tests - ${{ matrix.shard }}
         if: steps.changes.outputs.end_to_end == 'true'
+        timeout-minutes: 20
         run: |
           go run test.go -docker=true -pull=false -flavor=${{ env.BOOTSTRAP_FLAVOR }} -bootstrap-version=${{ env.BOOTSTRAP_VERSION }} --follow -shard ${{ matrix.shard }}

.github/workflows/docker_lite_build_check.yml

@@ -57,6 +57,7 @@ jobs:
           persist-credentials: 'false'
 
       - name: Build lite image
+        timeout-minutes: 15
         uses: docker/build-push-action@bcafcacb16a39f128d818304e6c9c0c18556b85f # v7.1.0
         with:
           context: .

.github/workflows/e2e_race.yml

@@ -59,16 +59,19 @@ jobs:
 
     - name: Tune the OS
       if: steps.changes.outputs.end_to_end == 'true'
+      timeout-minutes: 5
       uses: ./.github/actions/tune-os
 
     - name: Setup MySQL
       if: steps.changes.outputs.end_to_end == 'true'
+      timeout-minutes: 8
       uses: ./.github/actions/setup-mysql
       with:
         flavor: mysql-8.4
 
     - name: Get dependencies
       if: steps.changes.outputs.end_to_end == 'true'
+      timeout-minutes: 5
       run: |
         sudo apt-get update
         
@@ -81,6 +84,7 @@ jobs:
 
     - name: Run make minimaltools
       if: steps.changes.outputs.end_to_end == 'true'
+      timeout-minutes: 5
       run: |
         make minimaltools