Merged
Conversation
sapphi-red
commented
Jul 31, 2022
| @@ -107,6 +95,30 @@ module.exports = defineConfig({ | |||
| ] | |||
| }, | |||
| overrides: [ | |||
Member
Author
There was a problem hiding this comment.
sorted with packages -> playgrounds -> file extensions
antfu
approved these changes
Jul 31, 2022
|
💪🏾 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the strategy of configuring what file to run eslint.
Before: Use
eslint footo run lint on limited files and configure ignore/rules with.eslintignore/overrides.After: Use
eslint .to run lint on all files by default and configure ignore/rules with.eslintignore/overrides.By using
eslint ., it will be aligned with other eslint integrations such as eslint VSCode extension.close #7769 (because after this PR, if
pnpm lintdoes not output any errors, it means VSCode extension won't have any errors)requires eslint-types/eslint-define-config#120 to be released to fix the type error inupdated.eslintrc.cjs.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).