Skip to content

feat(create-vite): use framework brand glow color#8539

Merged
patak-cat merged 3 commits intovitejs:mainfrom
bluwy:feat-logo-color
Jun 11, 2022
Merged

feat(create-vite): use framework brand glow color#8539
patak-cat merged 3 commits intovitejs:mainfrom
bluwy:feat-logo-color

Conversation

@bluwy
Copy link
Copy Markdown
Member

@bluwy bluwy commented Jun 11, 2022

Description

Use brand color for framework presets

Ref: #8502 (comment)

Additional context

Also refactored lit's html structure, and other framwork's img attribute order to be consistent.

Also fix lit export extension

Examples:

image

image

image

image


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-cat
Copy link
Copy Markdown
Member

Awesome! 😍

@patak-cat patak-cat merged commit 3a21a5e into vitejs:main Jun 11, 2022
@bluwy bluwy deleted the feat-logo-color branch June 11, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants