Skip to content

feat(create-app): improve non-empty message for current dir#3117

Merged
patak-cat merged 2 commits intovitejs:mainfrom
jamesgeorge007:prompt-message
Apr 24, 2021
Merged

feat(create-app): improve non-empty message for current dir#3117
patak-cat merged 2 commits intovitejs:mainfrom
jamesgeorge007:prompt-message

Conversation

@jamesgeorge007
Copy link
Copy Markdown
Contributor

@jamesgeorge007 jamesgeorge007 commented Apr 23, 2021

Description

The user is greeted with the following message if he/she attempts to create a project in the current directory that is non-empty:-

Target directory . is not empty.

This PR aims at improving the message.

Additional context

N/A

What is the purpose of this pull request?

  • Bug fix
  • New Feature (Enhancement)
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Apr 23, 2021
@Shinigami92 Shinigami92 requested a review from patak-cat April 23, 2021 19:43
Comment thread packages/create-app/index.js Outdated
Comment thread packages/create-app/index.js Outdated
Comment thread packages/create-app/index.js Outdated
@Shinigami92 Shinigami92 requested a review from patak-cat April 24, 2021 09:02
@patak-cat patak-cat changed the title feat(create-app): better prompt message feat(create-app): improve non-empty message for current dir Apr 24, 2021
@patak-cat patak-cat merged commit c0a0a84 into vitejs:main Apr 24, 2021
@patak-cat
Copy link
Copy Markdown
Member

Thanks for the PR @jamesgeorge007!

@jamesgeorge007 jamesgeorge007 deleted the prompt-message branch April 24, 2021 09:18
TobiasMelen pushed a commit to TobiasMelen/vite that referenced this pull request May 3, 2021
)

Co-authored-by: Shinigami <chrissi92@hotmail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants