fix(create-vite): avoid usage of composite in TS configs#17774
Merged
Conversation
|
|
bluwy
approved these changes
Jul 30, 2024
Member
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
LGTM that it fixes that issue. We can still revisit the -b issue requirement again, and personally Sapphi's idea to keep a plain single tsconfig.json is still open for me.
dominikg
approved these changes
Jul 30, 2024
sapphi-red
approved these changes
Jul 31, 2024
aentwist
added a commit
to aentwist/AutoAFK
that referenced
this pull request
Aug 25, 2024
Type checking is currently not evaluated for referenced files. In order to make it evaluate, we have to use `--build`. However, this cannot be used with `--noEmit` and so will emit compiled files unless we use the solution tsconfig pattern. See - microsoft/TypeScript#53979 - vitejs/vite#15913 See also - https://www.typescriptlang.org/docs/handbook/project-references.html#overall-structure - vitejs/vite#17774
aentwist
added a commit
to aentwist/AutoAFK
that referenced
this pull request
Aug 25, 2024
Type checking is currently not evaluated for referenced files. In order to make it evaluate, we have to use `--build`. However, this cannot be used with `--noEmit` and so will emit compiled files unless we use the solution tsconfig pattern. See - microsoft/TypeScript#53979 - vitejs/vite#15913 See also - https://www.typescriptlang.org/docs/handbook/project-references.html#overall-structure - vitejs/vite#17774
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17638
After some investigation, composite is not required when the project by referenced an empty project. Which is why I'm #17732 in favor of this PR.
I've also done two things:
resolveJsonModulewhich is the default in bundler mode.This keeps the issues about needing
-band having silent exit 0 ontscat the root, I've made a comment here to the TS team about this issue: microsoft/TypeScript#25600 (comment)Also in TS 5.6, we will need to add
tsbuildInfoFileoption: https://devblogs.microsoft.com/typescript/announcing-typescript-5-6-beta/#tsbuildinfo-is-always-written.For now this is an error without
incrementalorcomposite.I'm in favor of adding it with incremental from now, but @dominikg felt like it was too much of an optimization for a starter