You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we should reconsider the usage of pnpm create in docs because plugins evolves more than the published templates (cc @patak-dev)
Do you have an idea to solve this issue? I think pnpm was going to start auto-upgrading to the latest version in range when there wasn't a lock, no? If that is the case, users should get the latest minor and for majors it makes sense we check first 🤔
Maybe we could automate receiving a PR when there is a major in a plugin?
The PR is stale because from what I understand they want to touch the package.json when doing so, which I also found bad.
I don't see why installing latest version on no lockfile but wihtout touching package.json (like every other package and manager and what did pnpm before) is not possible.
I agree there. I think Svelte added a .npmrc to all their templates. Maybe we should do that? cc @dominikg. We already waited quite a bit here. What I dislike is that all our templates will end up with a non-default pnpm setup moving forward if we go there, but maybe it could work as a temporary solution.
xinxinhe1810
pushed a commit
to xinxinhe1810/vite
that referenced
this pull request
Jul 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users have been hit by pnpm/pnpm#6463
I think we should reconsider the usage of
pnpm createin docs because plugins evolves more than the published templates (cc @patak-dev)