Skip to content

fix(template): bump react-swc plugin version#13699

Merged
bluwy merged 1 commit intomainfrom
fix-swc-version
Jul 3, 2023
Merged

fix(template): bump react-swc plugin version#13699
bluwy merged 1 commit intomainfrom
fix-swc-version

Conversation

@ArnaudBarre
Copy link
Copy Markdown
Member

Some users have been hit by pnpm/pnpm#6463

I think we should reconsider the usage of pnpm create in docs because plugins evolves more than the published templates (cc @patak-dev)

@ArnaudBarre ArnaudBarre requested a review from bluwy July 2, 2023 23:28
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ArnaudBarre ArnaudBarre added this to the 4.4 milestone Jul 3, 2023
@bluwy bluwy merged commit 8315f9e into main Jul 3, 2023
@bluwy bluwy deleted the fix-swc-version branch July 3, 2023 06:02
@patak-cat
Copy link
Copy Markdown
Member

I think we should reconsider the usage of pnpm create in docs because plugins evolves more than the published templates (cc @patak-dev)

Do you have an idea to solve this issue? I think pnpm was going to start auto-upgrading to the latest version in range when there wasn't a lock, no? If that is the case, users should get the latest minor and for majors it makes sense we check first 🤔
Maybe we could automate receiving a PR when there is a major in a plugin?

@ArnaudBarre
Copy link
Copy Markdown
Member Author

The PR is stale because from what I understand they want to touch the package.json when doing so, which I also found bad.
I don't see why installing latest version on no lockfile but wihtout touching package.json (like every other package and manager and what did pnpm before) is not possible.

@patak-cat
Copy link
Copy Markdown
Member

I agree there. I think Svelte added a .npmrc to all their templates. Maybe we should do that? cc @dominikg. We already waited quite a bit here. What I dislike is that all our templates will end up with a non-default pnpm setup moving forward if we go there, but maybe it could work as a temporary solution.

xinxinhe1810 pushed a commit to xinxinhe1810/vite that referenced this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants