fix(create-vite): remove baseUrl from Svelte configs #10200
Merged
patak-cat merged 1 commit intovitejs:mainfrom Sep 23, 2022
Merged
fix(create-vite): remove baseUrl from Svelte configs
#10200patak-cat merged 1 commit intovitejs:mainfrom
patak-cat merged 1 commit intovitejs:mainfrom
Conversation
The setting would need an accompanying Vite alias, which sounds like too much for a minimal starter template Fixes sveltejs/language-tools#1653
dummdidumm
commented
Sep 22, 2022
|
|
||
| - It brings its own routing solution which might not be preferable for some users. | ||
| - It is first and foremost a framework that just happens to use Vite under the hood, not a Vite app. | ||
| `vite dev` and `vite build` wouldn't work in a SvelteKit environment, for example. |
Contributor
Author
There was a problem hiding this comment.
took the liberty to also incorporate this readme change. That line is no longer true, vite dev/build is how you run SvelteKit now.
patak-cat
added
the
p3-minor-bug
patak-cat
approved these changes
Sep 22, 2022
jeffydc
approved these changes
Sep 23, 2022
bluwy
reviewed
Sep 23, 2022
Member
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
Sounds good to me. I'll make this change for create-vite-extra too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The setting would need an accompanying Vite alias, which sounds like too much for a minimal starter template
Fixes sveltejs/language-tools#1653
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).