Ensure sendMeasureItemEvent is only called for OS.TTN_SHOW or custom

tooltips

Prior to PR eclipse-platform#2241, sendMeasureItemEvent was only invoked when the
tooltip was not a CustomTooltip. However, after that change,
sendMeasureItemEvent is now called for all tooltips.

This results in an unintended side effect: sendMeasureItemEvent compares
the item's width(obtained from TableItem.getBounds()) to the width of column (via OS.LVM_GETCOLUMNWIDTH) it is present in and sometimes
concludes incorrectly that the item doesn't fit. This causes an
unnecessary scrollbar to appear, even though the item is fully contained
within the column.

While the root cause lies in how column item width is calculated (which
should be addressed separately), this change acts as a temporary fix to
prevent scrollbars from appearing erroneously particularly in the
MultipleHyperlinkPresenter.

This workaround aligns with the original behavior prior to PR eclipse-platform#2241 as
sendMeasureItemEvent would not be called for non customToolTip and
restores expected UI behavior for now.

Author: arunjose696

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java

@@ -7175,6 +7175,7 @@ private LRESULT positionTooltip(NMHDR hdr, long lParam) {
 	OS.ScreenToClient (handle, pt);
 	pinfo.x = pt.x;
 	pinfo.y = pt.y;
+	System.out.println(hdr.code);
 	/*
 	*  Bug in Windows.  When LVM_SUBITEMHITTEST is used to hittest
 	*  a point that is above the table, instead of returning -1 to
@@ -7188,39 +7189,42 @@ private LRESULT positionTooltip(NMHDR hdr, long lParam) {
 		if (newFont != 0) oldFont = OS.SelectObject (hDC, newFont);
 		long hFont = item.fontHandle (pinfo.iSubItem);
 		if (hFont != -1) hFont = OS.SelectObject (hDC, hFont);
-		Event event = sendMeasureItemEvent (item, pinfo.iItem, pinfo.iSubItem, hDC);
-		if (!isDisposed () && !item.isDisposed ()) {
-			RECT itemRect = new RECT ();
-			Rectangle boundsInPixels = Win32DPIUtils.pointToPixel(event.getBounds(), getZoom());
-			OS.SetRect (itemRect, boundsInPixels.x, boundsInPixels.y, boundsInPixels.x + boundsInPixels.width, boundsInPixels.y + boundsInPixels.height);
-			if (hdr.code == OS.TTN_SHOW) {
-				RECT toolRect = isCustomToolTip() ? toolTipRect (itemRect) : itemRect;
-				OS.MapWindowPoints (handle, 0, toolRect, 2);
-				long hwndToolTip = OS.SendMessage (handle, OS.LVM_GETTOOLTIPS, 0, 0);
-				int flags = OS.SWP_NOACTIVATE | OS.SWP_NOZORDER;
-				Rectangle adjustedTooltipBounds = getDisplay().fitRectangleBoundsIntoMonitorWithCursor(toolRect);
-				OS.SetWindowPos(hwndToolTip, 0, adjustedTooltipBounds.x, adjustedTooltipBounds.y,
-						adjustedTooltipBounds.width, adjustedTooltipBounds.height, flags);
-				result = LRESULT.ONE;
-			} else if (isCustomToolTip()) {
-				NMTTDISPINFO lpnmtdi = new NMTTDISPINFO ();
-				OS.MoveMemory (lpnmtdi, lParam, NMTTDISPINFO.sizeof);
-				if (lpnmtdi.lpszText != 0) {
-					OS.MoveMemory (lpnmtdi.lpszText, new char [1], 2);
-					OS.MoveMemory (lParam, lpnmtdi, NMTTDISPINFO.sizeof);
-				}
-				RECT cellRect = item.getBounds (pinfo.iItem, pinfo.iSubItem, true, true, true, true, hDC);
-				RECT clientRect = new RECT ();
-				OS.GetClientRect (handle, clientRect);
-				if (itemRect.right > cellRect.right || itemRect.right > clientRect.right) {
-					//TEMPORARY CODE
-					String string = " ";
-					Shell shell = getShell ();
-					char [] chars = new char [string.length () + 1];
-					string.getChars (0, string.length (), chars, 0);
-					shell.setToolTipText (lpnmtdi, chars);
-					OS.MoveMemory (lParam, lpnmtdi, NMTTDISPINFO.sizeof);
+		if (!isDisposed() && !item.isDisposed()) {
+			if (isCustomToolTip() || hdr.code == OS.TTN_SHOW) {
+				Event event = sendMeasureItemEvent(item, pinfo.iItem, pinfo.iSubItem, hDC);
+				RECT itemRect = new RECT();
+				Rectangle boundsInPixels = Win32DPIUtils.pointToPixel(event.getBounds(), getZoom());
+				OS.SetRect(itemRect, boundsInPixels.x, boundsInPixels.y, boundsInPixels.x + boundsInPixels.width,
+						boundsInPixels.y + boundsInPixels.height);
+				if (hdr.code == OS.TTN_SHOW) {
+					RECT toolRect = isCustomToolTip() ? toolTipRect(itemRect) : itemRect;
+					OS.MapWindowPoints(handle, 0, toolRect, 2);
+					long hwndToolTip = OS.SendMessage(handle, OS.LVM_GETTOOLTIPS, 0, 0);
+					int flags = OS.SWP_NOACTIVATE | OS.SWP_NOZORDER;
+					Rectangle adjustedTooltipBounds = getDisplay().fitRectangleBoundsIntoMonitorWithCursor(toolRect);
+					OS.SetWindowPos(hwndToolTip, 0, adjustedTooltipBounds.x, adjustedTooltipBounds.y,
+							adjustedTooltipBounds.width, adjustedTooltipBounds.height, flags);
 					result = LRESULT.ONE;
+				} else {
+					NMTTDISPINFO lpnmtdi = new NMTTDISPINFO();
+					OS.MoveMemory(lpnmtdi, lParam, NMTTDISPINFO.sizeof);
+					if (lpnmtdi.lpszText != 0) {
+						OS.MoveMemory(lpnmtdi.lpszText, new char[1], 2);
+						OS.MoveMemory(lParam, lpnmtdi, NMTTDISPINFO.sizeof);
+					}
+					RECT cellRect = item.getBounds(pinfo.iItem, pinfo.iSubItem, true, true, true, true, hDC);
+					RECT clientRect = new RECT();
+					OS.GetClientRect(handle, clientRect);
+					if (itemRect.right > cellRect.right || itemRect.right > clientRect.right) {
+						// TEMPORARY CODE
+						String string = " ";
+						Shell shell = getShell();
+						char[] chars = new char[string.length() + 1];
+						string.getChars(0, string.length(), chars, 0);
+						shell.setToolTipText(lpnmtdi, chars);
+						OS.MoveMemory(lParam, lpnmtdi, NMTTDISPINFO.sizeof);
+						result = LRESULT.ONE;
+					}
 				}
 			}
 		}