address Jean's review comments

thomas-fossati · thomas-fossati · commit 53dc640cf75a · 2024-12-05T18:30:24.000+01:00
Signed-off-by: Thomas Fossati &lt;thomas.fossati@linaro.org&gt;
diff --git a/src/token/realm.rs b/src/token/realm.rs
@@ -28,7 +28,7 @@ bitmask! {
         HashAlg    = 0x10,
         Rak        = 0x20,
         RakHashAlg = 0x40,
-        Profile = 0x80,
+        Profile    = 0x80,
     }
 }
 
@@ -89,6 +89,8 @@ impl Realm {
     }
 
     fn parse(&mut self, contents: Vec<(Value, Value)>) -> Result<(), Error> {
+        // Extract the profile claim first.  This is because the RAK claim
+        // (44237) has different encodings depending on the profile value.
         for (k, v) in contents.iter() {
             if let Value::Integer(i) = k {
                 match (*i).into() {

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ bitmask! {`
`28`	`28`	`HashAlg = 0x10,`
`29`	`29`	`Rak = 0x20,`
`30`	`30`	`RakHashAlg = 0x40,`
`31`		`- Profile = 0x80,`
	`31`	`+ Profile = 0x80,`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`
`@@ -89,6 +89,8 @@ impl Realm {`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`fn parse(&mut self, contents: Vec<(Value, Value)>) -> Result<(), Error> {`
	`92`	`+ // Extract the profile claim first. This is because the RAK claim`
	`93`	`+ // (44237) has different encodings depending on the profile value.`
`92`	`94`	`for (k, v) in contents.iter() {`
`93`	`95`	`if let Value::Integer(i) = k {`
`94`	`96`	`match (*i).into() {`