fix: improve parsing logic to handle empty results

Author: zou2699

pkg/termination/parse.go

@@ -39,14 +39,17 @@ func ParseMessage(logger *zap.SugaredLogger, msg string) ([]result.RunResult, er
 		return nil, fmt.Errorf("parsing message json: %w, msg: %s", err, msg)
 	}
 
-	for i, rr := range r {
-		if rr == (result.RunResult{}) {
+	writeIndex := 0
+	for _, rr := range r {
+		if rr != (result.RunResult{}) {
 			// Erase incorrect result
-			r[i] = r[len(r)-1]
-			r = r[:len(r)-1]
+			r[writeIndex] = rr
+			writeIndex++
+		} else {
 			logger.Errorf("termination message contains non taskrun or pipelineresource result keys")
 		}
 	}
+	r = r[:writeIndex]
 
 	// Remove duplicates (last one wins) and sort by key.
 	m := map[string]result.RunResult{}

pkg/termination/parse_test.go

@@ -63,6 +63,17 @@ func TestParseMessage(t *testing.T) {
 			Key:   "foo",
 			Value: "last",
 		}},
+	}, {
+		desc: "duplicate keys with incorrect result",
+		msg: `[
+		{"key":"foo","value":"first"},
+		{},
+		{"key":"foo","value":"middle"},
+		{"key":"foo","value":"last"}]`,
+		want: []result.RunResult{{
+			Key:   "foo",
+			Value: "last",
+		}},
 	}, {
 		desc: "sorted by key",
 		msg: `[