-
Notifications
You must be signed in to change notification settings - Fork 47
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
If I have misunderstood this then my apologies.
The valkeycompat.NewAdapter sets maxp to the current no. of cores. This is then used to scale out commands.
Even if one is running on 1 or less cores most operations are IO bound so this limit is unnecessarily restrictive.
Secondly this kind of setting should be user-controlled and not something arbitrarily set internally.
A better interface would be to add an option that allows the user to set this themselves using the functional option pattern.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed