Skip to content

valkeycompat NewAdapter sets maxp incorrectly #96

@eccles

Description

@eccles

If I have misunderstood this then my apologies.

The valkeycompat.NewAdapter sets maxp to the current no. of cores. This is then used to scale out commands.
Even if one is running on 1 or less cores most operations are IO bound so this limit is unnecessarily restrictive.

Secondly this kind of setting should be user-controlled and not something arbitrarily set internally.

A better interface would be to add an option that allows the user to set this themselves using the functional option pattern.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions