Skip to content

Commit 7d2f578

Browse files
authored
Merge pull request DefectDojo#14063 from manuel-sommer/google_artifactory_vulnid
🎉 Advance Google Cloud Artifact Scan to parse vulnid
2 parents 4590d4b + 5d29adb commit 7d2f578

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

dojo/tools/gcloud_artifact_scan/parser.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ def get_findings(self, json_output, test):
5555
finding.fix_available = vuln["vulnerability"].get("fixAvailable")
5656
if vuln["vulnerability"].get("cvssScore"):
5757
finding.cvssv3_score = vuln["vulnerability"].get("cvssScore")
58+
if vuln["vulnerability"]["shortDescription"]:
59+
finding.unsaved_vulnerability_ids = [vuln["vulnerability"]["shortDescription"]]
5860
findings.append(finding)
5961
return findings
6062

unittests/tools/test_gcloud_artifact_scan_parser.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ def test_parse_file_with_multiple_vuln_has_multiple_findings(self):
1717
self.assertEqual("Critical", finding.severity)
1818
finding = findings[2]
1919
self.assertEqual("projects/goog-vulnz/notes/CVE-2023-29404", finding.title)
20+
self.assertEqual("CVE-2023-29404", finding.unsaved_vulnerability_ids[0])
2021
self.assertEqual("Critical", finding.severity)
2122

2223
def test_parse_file_artifact_analysis_occurrences_sample(self):
@@ -33,3 +34,4 @@ def test_parse_file_artifact_analysis_occurrences_sample(self):
3334
finding = findings[2]
3435
self.assertEqual("projects/goog-vulnz/notes/CVE-2022-37620", finding.title)
3536
self.assertEqual("High", finding.severity)
37+
self.assertEqual("CVE-2022-37620", finding.unsaved_vulnerability_ids[0])

0 commit comments

Comments
 (0)