Revert "repl: Mitigate vm nodejs#548 function redefinition issue"

This reverts commit bb9eabe.

The issue is fixed upstream in V8. Thus we do not need this workaround in
REPL. Keeping the edgecase test.

Author: fhinkel

lib/repl.js

@@ -498,7 +498,19 @@ function REPLServer(prompt,
     }
 
     var evalCmd = self.bufferedCommand + cmd;
-    evalCmd = preprocess(evalCmd);
+    if (/^\s*\{/.test(evalCmd) && /\}\s*$/.test(evalCmd)) {
+      // It's confusing for `{ a : 1 }` to be interpreted as a block
+      // statement rather than an object literal.  So, we first try
+      // to wrap it in parentheses, so that it will be interpreted as
+      // an expression.
+      evalCmd = '(' + evalCmd + ')\n';
+      self.wrappedCmd = true;
+    } else {
+      // otherwise we just append a \n so that it will be either
+      // terminated, or continued onto the next expression if it's an
+      // unexpected end of input.
+      evalCmd = evalCmd + '\n';
+    }
 
     debug('eval %j', evalCmd);
     self.eval(evalCmd, self.context, 'repl', finish);
@@ -555,26 +567,6 @@ function REPLServer(prompt,
       // Display prompt again
       self.displayPrompt();
     }
-
-    function preprocess(code) {
-      let cmd = code;
-      if (/^\s*\{/.test(cmd) && /\}\s*$/.test(cmd)) {
-        // It's confusing for `{ a : 1 }` to be interpreted as a block
-        // statement rather than an object literal.  So, we first try
-        // to wrap it in parentheses, so that it will be interpreted as
-        // an expression.
-        cmd = `(${cmd})`;
-        self.wrappedCmd = true;
-      } else {
-        // Mitigate https://github.com/nodejs/node/issues/548
-        cmd = cmd.replace(/^\s*function\s+([^(]+)/,
-                  (_, name) => `var ${name} = function ${name}`);
-      }
-      // Append a \n so that it will be either
-      // terminated, or continued onto the next expression if it's an
-      // unexpected end of input.
-      return `${cmd}\n`;
-    }
   });
 
   self.on('SIGCONT', function() {

test/known_issues/test-repl-function-redefinition-edge-case.js renamed to test/parallel/test-repl-function-redefinition-edge-case.js

@@ -13,7 +13,7 @@ r.input.emit('data', 'function a() { return 42; } (1)\n');
 r.input.emit('data', 'a\n');
 r.input.emit('data', '.exit');
 
-const expected = '1\n[Function a]\n';
+const expected = '1\n[Function: a]\n';
 const got = r.output.accumulator.join('');
 assert.strictEqual(got, expected);