Skip to content

Commit 825cbc3

Browse files
committed
[native] Allow non power of two task concurrency for native execution
Native execution does not have this limitation. Similar to task_writer_count.
1 parent ed31868 commit 825cbc3

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

presto-main-base/src/main/java/com/facebook/presto/SystemSessionProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,7 @@ public SystemSessionProperties(
549549
Integer.class,
550550
taskManagerConfig.getTaskConcurrency(),
551551
false,
552-
value -> validateValueIsPowerOfTwo(requireNonNull(value, "value is null"), TASK_CONCURRENCY),
552+
featuresConfig.isNativeExecutionEnabled() ? value -> validateIntegerValue(value, TASK_CONCURRENCY, 1, false) : value -> validateValueIsPowerOfTwo(requireNonNull(value, "value is null"), TASK_CONCURRENCY),
553553
value -> value),
554554
booleanProperty(
555555
TASK_SHARE_INDEX_LOADING,

presto-main-base/src/main/java/com/facebook/presto/execution/TaskManagerConfig.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import com.facebook.airlift.configuration.DefunctConfig;
1919
import com.facebook.airlift.configuration.LegacyConfig;
2020
import com.facebook.presto.memory.HighMemoryTaskKillerStrategy;
21-
import com.facebook.presto.util.PowerOfTwo;
2221
import io.airlift.units.DataSize;
2322
import io.airlift.units.DataSize.Unit;
2423
import io.airlift.units.Duration;
@@ -486,7 +485,6 @@ public TaskManagerConfig setPartitionedWriterCount(Integer partitionedWriterCoun
486485
}
487486

488487
@Min(1)
489-
@PowerOfTwo
490488
public int getTaskConcurrency()
491489
{
492490
return taskConcurrency;

0 commit comments

Comments
 (0)