Relations: Fix descendants query to exclude parent item (#21162)

* Relations: Fix descendants query to exclude parent item

The GetPagedDescendantsInReferences query was using a path LIKE without
the comma delimiter, causing it to match both the parent item and its
descendants. This resulted in the trash confirmation dialog showing
the item being deleted in the "descending items with dependencies"
list.

Changed the WhereLike call to use ",%" suffix instead of just "%",
so the query only matches actual descendants (items whose path
starts with the parent's path followed by a comma).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Add integration test to verify behaviour.

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Andy Butland <abutland73@gmail.com>

Author: 3 people

src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs

@@ -282,11 +282,11 @@ public IEnumerable<RelationItemModel> GetPagedDescendantsInReferences(
                 .From<NodeDto>()
                 .Where<NodeDto>(x => x.UniqueId == parentKey);
 
-            // Gets the descendants of the parent node
+            // Gets the descendants of the parent node (using ",%" to exclude the parent itself)
             Sql<ISqlContext> subQuery = sqlContext.Sql()
                 .Select<NodeDto>(x => x.NodeId)
                 .From<NodeDto>()
-                .WhereLike<NodeDto>(x => x.Path, subsubQuery);
+                .WhereLike<NodeDto>(x => x.Path, subsubQuery, ",%");
 
             ISqlSyntaxProvider sx = sqlContext.SqlSyntax;
             string[] columns = [

tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/TrackedReferencesServiceTests.cs

@@ -24,6 +24,8 @@ internal class TrackedReferencesServiceTests : UmbracoIntegrationTest
 
     private Content Root1 { get; set; }
 
+    private Content Child1 { get; set; }
+
     private Content Root2 { get; set; }
 
     private IContentType ContentType { get; set; }
@@ -43,14 +45,22 @@ protected virtual void CreateTestData()
         ContentType = new ContentTypeBuilder()
             .WithName("Page")
             .AddPropertyType()
-                .WithAlias("ContentPicker")
-                .WithName("contentPicker")
+                .WithAlias("contentPicker")
+                .WithName("ContentPicker")
+                .WithDataTypeId(1046)
+                .WithPropertyEditorAlias(Constants.PropertyEditors.Aliases.ContentPicker)
+                .Done()
+            .AddPropertyType()
+                .WithAlias("contentPicker2")
+                .WithName("ContentPicker2")
                 .WithDataTypeId(1046)
                 .WithPropertyEditorAlias(Constants.PropertyEditors.Aliases.ContentPicker)
-            .Done()
+                .Done()
             .Build();
 
         ContentTypeService.Save(ContentType);
+        ContentType.AllowedContentTypes = [new ContentTypeSort(ContentType.Key, 0, ContentType.Alias)];
+        ContentTypeService.Save(ContentType);
 
         Root1 = new ContentBuilder()
             .WithContentType(ContentType)
@@ -60,12 +70,22 @@ protected virtual void CreateTestData()
         ContentService.Save(Root1);
         ContentService.Publish(Root1, ["*"]);
 
+        Child1 = new ContentBuilder()
+            .WithContentType(ContentType)
+            .WithName("Child 1")
+            .WithParentId(Root1.Id)
+            .Build();
+
+        ContentService.Save(Child1);
+        ContentService.Publish(Child1, ["*"]);
+
         Root2 = new ContentBuilder()
             .WithContentType(ContentType)
             .WithName("Root 2")
             .WithPropertyValues(new
             {
-                contentPicker = Udi.Create(Constants.UdiEntityType.Document, Root1.Key) // contentPicker is the alias of the property type
+                contentPicker = Udi.Create(Constants.UdiEntityType.Document, Root1.Key),  // contentPicker is the alias of the property type
+                contentPicker2 = Udi.Create(Constants.UdiEntityType.Document, Child1.Key),
             })
             .Build();
 
@@ -104,6 +124,25 @@ public async Task Get_Relations_For_Non_Existing_Page_Returns_Not_Found()
         });
     }
 
+    [Test]
+    public async Task Get_Descendants_In_References_For_Existing_Page_Returns_Expected_Results()
+    {
+        var sut = GetRequiredService<ITrackedReferencesService>();
+
+        var actual = await sut.GetPagedDescendantsInReferencesAsync(Root1.Key, UmbracoObjectTypes.Document, 0, 10, true);
+
+        Assert.Multiple(() =>
+        {
+            Assert.IsTrue(actual.Success);
+            Assert.AreEqual(GetReferencesOperationStatus.Success, actual.Status);
+
+            var itemKeys = actual.Result.Items.Select(x => x.NodeKey).ToList();
+            Assert.IsFalse(itemKeys.Contains(Root1.Key)); // Should not return the parent itself (see: https://github.com/umbraco/Umbraco-CMS/pull/21162)
+            Assert.AreEqual(1, itemKeys.Count);
+            Assert.IsTrue(itemKeys.Contains(Child1.Key));
+        });
+    }
+
     [Test]
     public async Task Get_Descendants_In_References_For_Non_Existing_Page_Returns_Not_Found()
     {