Skip to content

Commit 827d3b9

Browse files
authored
Remove unnecessary casts (#446)
* Remove unnecessary casts Since incremental has been released, we have type hints for it now. * Add news fragment
1 parent 45ff8ce commit 827d3b9

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/towncrier/_project.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
from importlib import import_module
1414
from types import ModuleType
15-
from typing import cast
1615

1716
from incremental import Version
1817

@@ -52,7 +51,7 @@ def get_version(package_dir: str, package: str) -> str:
5251
return version.strip()
5352

5453
if isinstance(version, Version):
55-
return cast(str, version.base().strip())
54+
return version.base().strip()
5655

5756
if isinstance(version, tuple):
5857
return ".".join(map(str, version)).strip()
@@ -79,6 +78,6 @@ def get_project_name(package_dir: str, package: str) -> str:
7978

8079
if isinstance(version, Version):
8180
# Incremental has support for package names
82-
return cast(str, version.package)
81+
return version.package
8382

8483
raise TypeError(f"Unsupported type for __version__: {type(version)}")

src/towncrier/newsfragments/446.misc

Whitespace-only changes.

0 commit comments

Comments
 (0)