Fix other tests of mos6502 #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binop::UnaryNot, Binop::LessEqual and Binop:BitOr were implemented. Also needed to finish the implementation of the global variables, which is still buggy for some reason.
|
@Miezekatze64 do you see any problems in here? |
|
Looks good for me! Especially for the globals/externals I already have a working implementation. I'll open a pull request after this one is merged. |
|
@Miezekatze64 @antox01 thank you so much for the contribution! |
Miezekatze64
added a commit
to Miezekatze64/b
that referenced
this pull request
Jun 22, 2025
Miezekatze64
added a commit
to Miezekatze64/b
that referenced
this pull request
Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented other instructions to fix more 6502 tests.
Some of the functions where implemented in
libb/6502.band because of that I was able to implement functions like printf but still got some basic Op not completely implemented.Some of them not work completely well for some reasons, like the usage of globals.
We can keep it open until I, or someone else, doesn't fix them.