Skip to content

fix(pb): protocol buffer file syntax compatibility issue #6386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release_v4.8.1
Choose a base branch
from
Open

fix(pb): protocol buffer file syntax compatibility issue #6386

wants to merge 1 commit into from

Conversation

wifiwang777
Copy link

What does this PR do?
fix

Why are these changes required?
I can't compile protocol buffer file

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@kuny0707 kuny0707 moved this to In Review in java-tron Jul 4, 2025
@lxcmyf
Copy link
Contributor

lxcmyf commented Jul 4, 2025 •
edited
Loading

@wifiwang777
Are you saying that writing 'x' in uppercase before would cause your project to fail to compile? Please let me know how you did it? Under what circumstances will compilation fail?

@kuny0707 kuny0707 changed the title fix pb file error fix(pb): protocol buffer file syntax compatibility issue Jul 4, 2025
@wifiwang777
Copy link
Author

@wifiwang777 Are you saying that writing 'x' in uppercase before would cause your project to fail to compile? Please let me know how you did it? Under what circumstances will compilation fail?

I imported the pb file into Postman and encountered an error when testing the GRPC request.

@troncommons troncommons mentioned this pull request Jun 12, 2025
Open
6 tasks
@lxcmyf
Copy link
Contributor

lxcmyf commented Jul 4, 2025

@wifiwang777
You can first use the PB protocol here: https://github.com/tronprotocol/protocol
This PR will also be included in the future. Thank you for your correction.

Sunny6889
Sunny6889 approved these changes Jul 10, 2025
View reviewed changes
Copy link

@Sunny6889 Sunny6889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job to fix it.

@kuny0707 kuny0707 added the topic:deployment configuration, startup command label Jul 14, 2025
@GordonLtron GordonLtron mentioned this pull request Jul 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuny0707 kuny0707 kuny0707 approved these changes

@317787106 317787106 317787106 approved these changes

@halibobo1205 halibobo1205 halibobo1205 approved these changes

@bladehan1 bladehan1 bladehan1 approved these changes

@barbatos2011 barbatos2011 barbatos2011 approved these changes

@Sunny6889 Sunny6889 Sunny6889 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@wifiwang777 wifiwang777

Labels
topic:deployment configuration, startup command
Projects
java-tron
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@wifiwang777 @lxcmyf @kuny0707 @317787106 @halibobo1205 @bladehan1 @barbatos2011 @Sunny6889