feat(jsonrpc): implement eth_getBlockReceipts #6379
Conversation
…Receipt Constructor
framework/src/main/java/org/tron/core/services/jsonrpc/types/TransactionReceipt.java
Outdated
Show resolved
Hide resolved
| long cumulativeGas = 0; | ||
| long cumulativeLogCount = 0; | ||
|
|
||
| for (int index = 0; index < infoList.getTransactionInfoCount(); index++) { |
There was a problem hiding this comment.
Suggest judging the size of the list as empty and then recycling it.
There was a problem hiding this comment.
Suggest judging the size of the list as empty and then recycling it.
Hi, If the list is empty, the loop condition index < 0 will skip the loop entirely and return null
| TransactionInfo info = infoList.getTransactionInfo(index); | ||
| ResourceReceipt resourceReceipt = info.getReceipt(); | ||
|
|
||
| if (info.getId().equals(txId)) { |
There was a problem hiding this comment.
Need to check if info.getId() is null.
There was a problem hiding this comment.
Need to check if
info.getId()is null.
Thank you for your suggestion. Adding null checks can improve code robustness, but I believe TransactionInfo objects should contain valid IDs. A null ID typically indicates data corruption or a system error, which points to serious issues in java-tron. In most cases, this is an unnecessary check, and adding it in every loop will increase overhead.
| throws JsonRpcInvalidParamsException, JsonRpcInternalException { | ||
| Block block = wallet.getByJsonBlockId(blockNumOrTag); | ||
| if (block == null) { | ||
| return null; |
There was a problem hiding this comment.
To be consistent with ethereum eth_getBlockReceipts logic, return null for blocks that are not found.
| long cumulativeGas = 0; | ||
| long cumulativeLogCount = 0; | ||
|
|
||
| for (int index = 0; index < transactionInfoList.getTransactionInfoCount(); index++) { |
There was a problem hiding this comment.
Need to check if the transactionInfoList is empty. If it is empty, it can be returned directly without going down.
There was a problem hiding this comment.
Hi, If the transactionInfoList is empty, the loop condition index < 0 will skip the loop entirely and return receipts which is empty ArrayList<>()
What does this PR do?
Implement eth_getBlockReceipts method, from #5910
Why are these changes required?
This PR has been tested by:
Follow up
Extra details